Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass Engine Update #1220

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

sleepyyapril
Copy link
Contributor

Description

An attempt to do all engine updates in one go. Not focusing on content associated, only what's needed for it to run and any bug fixes.


@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Nov 14, 2024
@sleepyyapril

This comment was marked as resolved.

@sleepyyapril
Copy link
Contributor Author

I have run into a problem I do not know how to fix. Woe.

@OCOtheOmega
Copy link

I have run into a problem I do not know how to fix. Woe.

That why engine update for EE is pain and @VMSolidus take a lot of time for updates.

@FoxxoTrystan
Copy link
Member

OH LORD...

ENGINES UPDATES.... ITS AGONY.

ElectroJr and others added 5 commits November 14, 2024 14:29
* partial buckling refactor

* git mv test

* change test namespace

* git mv test

* Update test namespace

* Add pulling test

* Network BuckleTime

* Add two more tests

* smelly
* Replaced uses of Dirty(Component) with Dirty(Uid, Component)
Modified some systems (notably pulling-related) to use uids.

* Missed a few

* Revert changes to pulling

* No
@VMSolidus
Copy link
Member

By request, I have implemented space-wizards/space-station-14#26238
in this PR.

@VMSolidus
Copy link
Member

@VMSolidus
Copy link
Member

Mfw the linter fail is in a system that I'm the Codeowner of.

@github-actions github-actions bot added the Changes: UI Changes any XAML files label Nov 15, 2024
@VMSolidus
Copy link
Member

Added this to the PR:
space-wizards/space-station-14#27933

This is going to break several EE-specific systems, which now need to be fixed...

ElectroJr and others added 5 commits November 14, 2024 22:48
* partial buckling refactor

* git mv test

* change test namespace

* git mv test

* Update test namespace

* Add pulling test

* Network BuckleTime

* Add two more tests

* smelly
@gluesniffler
Copy link
Contributor

Added this to the PR: space-wizards/space-station-14#27933

This is going to break several EE-specific systems, which now need to be fixed...

i actually needed this, godspeed funny birb man

@sleepyyapril
Copy link
Contributor Author

sleepyyapril commented Nov 15, 2024

Added this to the PR: space-wizards/space-station-14#27933
This is going to break several EE-specific systems, which now need to be fixed...

i actually needed this, godspeed funny birb man

I'm actively making it work, you should likely wait until it does.

sleepyyapril and others added 4 commits November 15, 2024 00:47
* Extra checks to prevent ghosts spawning on terminating maps/grids

* Add test for grid deletion
* Add failing unbuckle InteractHand test

* Skip trybuckle if strap doesn't have space

* Unbuckle others not just user

* Fix test failing due to delay

* Change to raise event instead of calling OnInteractHand

* Add test for buckle and unbuckle on InteractHand

* Add tick delay

* Remove unneeded tick delay and clean up

* Comment code

* Cleanup

* Swap to fastest checks first

* Fix reading empty sequence when there are no buckled entities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: UI Changes any XAML files Changes: YML Changes any yml files Status: Do Not Merge Do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.