test: refactor all fixtures into boxed steps #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexfreska
commented
Oct 29, 2024
•
alexfreska
commented
- Refacted all fixtures into boxed steps. This should provide much clearer test output and easier debugging.
- Added more expect calls to many fixtures so that they fail with the expect deadline rather than test timeout which is much higher.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: e3c50c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 29, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alexfreska and the rest of your teammates on |
alexfreska
force-pushed
the
feat_renterd_directory_mode_files_multiselect_and_batch_delete
branch
2 times, most recently
from
b7d71b6
to
77069ed
Compare
alexfreska
force-pushed
the
test_refactor_all_fixtures_into_boxed_steps
branch
from
dc96141
to
135a724
Compare
telestrial
approved these changes
Oct 29, 2024
alexfreska
force-pushed
the
feat_renterd_directory_mode_files_multiselect_and_batch_delete
branch
from
77069ed
to
9e9d2bc
Compare
alexfreska
force-pushed
the
test_refactor_all_fixtures_into_boxed_steps
branch
from
135a724
to
e3c50c6
Compare
alexfreska
changed the base branch from
feat_renterd_directory_mode_files_multiselect_and_batch_delete
to
graphite-base/801
alexfreska
force-pushed
the
test_refactor_all_fixtures_into_boxed_steps
branch
from
e3c50c6
to
38cbba2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.