-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(renterd): files explorer multiselect and batch delete #785
feat(renterd): files explorer multiselect and batch delete #785
Conversation
alexfreska
commented
Oct 18, 2024
•
edited
Loading
edited
- The directory-based file explorer now supports multiselect across any files and directories.
- The directory-based file explorer multiselect menu now supports batch deletion of selected files and directories.
- Navigating into a directory in the file explorer is now by clicking on the directory name rather than anywhere on the row.
- The "all files" file explorer now supports multiselect across any files.
- The "all files" file explorer multiselect menu now supports batch deletion of selected files.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 9e9d2bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alexfreska and the rest of your teammates on Graphite |
1a9941b
to
70ee5a4
Compare
f82aa4f
to
474ab7c
Compare
70ee5a4
to
7ee383a
Compare
474ab7c
to
5f366a6
Compare
5f366a6
to
1342b09
Compare
7ee383a
to
231777c
Compare
1342b09
to
b3df871
Compare
231777c
to
3a8a307
Compare
b3df871
to
dc924ba
Compare
b98001b
to
5242973
Compare
dc924ba
to
078fb86
Compare
5242973
to
a0316dc
Compare
078fb86
to
44c4c86
Compare
7b7f0d2
to
ece57e3
Compare
4fe25a0
to
19e1aac
Compare
ece57e3
to
bde6f3a
Compare
19e1aac
to
d680c22
Compare
d680c22
to
7cabd33
Compare
7cabd33
to
daba970
Compare
bde6f3a
to
ed264a0
Compare
daba970
to
b7d71b6
Compare
b7d71b6
to
77069ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may seem frictional to my last comment on multi-select about inviting users into the feature: if users must now click on the directory name exactly, is there an invitation to that? underlined or onHover underlined or something to that effect?
It may end up that some of the triggers/actions a user takes within this framework may need to be adjusted to feel more comfortable. Might be worth it to hit the discord when this lands and garner some feedback around what feels natural.
77069ed
to
9e9d2bc
Compare
@telestrial agreed, I think after applying this feature to most of the tables we should review them all and make some refinements. I already made some changes (moving the selection from checkboxes to entire row) when adding to the file explorer because it felt more intuitive and consistent, but a few of the upcoming tables have other interacts when clicking a row that will need to be moved - so I think there will be some refinements to make once the first pass is done and have an inventory of all the interactions to support. |