Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renterd): files explorer multiselect and batch delete #785

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Oct 18, 2024

  • The directory-based file explorer now supports multiselect across any files and directories.
  • The directory-based file explorer multiselect menu now supports batch deletion of selected files and directories.
  • Navigating into a directory in the file explorer is now by clicking on the directory name rather than anywhere on the row.
  • The "all files" file explorer now supports multiselect across any files.
  • The "all files" file explorer multiselect menu now supports batch deletion of selected files.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renterd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 11:32pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 11:32pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 11:32pm
hostd ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 11:32pm
website ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 11:32pm

Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 9e9d2bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
renterd Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 1a9941b to 70ee5a4 Compare October 18, 2024 20:40
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from f82aa4f to 474ab7c Compare October 18, 2024 20:40
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 70ee5a4 to 7ee383a Compare October 18, 2024 21:54
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from 474ab7c to 5f366a6 Compare October 18, 2024 21:54
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from 5f366a6 to 1342b09 Compare October 18, 2024 23:17
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 7ee383a to 231777c Compare October 23, 2024 12:15
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from 1342b09 to b3df871 Compare October 23, 2024 12:15
@alexfreska alexfreska force-pushed the refactor_refine_multiselect_api branch from 231777c to 3a8a307 Compare October 24, 2024 14:30
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from b3df871 to dc924ba Compare October 24, 2024 14:30
@alexfreska alexfreska changed the base branch from refactor_refine_multiselect_api to refactor_apps_persist_layouts_between_page_transitions October 24, 2024 14:31
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from b98001b to 5242973 Compare October 24, 2024 14:59
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from dc924ba to 078fb86 Compare October 24, 2024 14:59
@alexfreska alexfreska force-pushed the refactor_apps_persist_layouts_between_page_transitions branch from 5242973 to a0316dc Compare October 24, 2024 19:51
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from 078fb86 to 44c4c86 Compare October 24, 2024 19:52
@alexfreska alexfreska force-pushed the feat_actions_bottom branch 2 times, most recently from 7b7f0d2 to ece57e3 Compare October 28, 2024 17:20
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from 4fe25a0 to 19e1aac Compare October 28, 2024 17:20
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from 19e1aac to d680c22 Compare October 28, 2024 23:22
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from d680c22 to 7cabd33 Compare October 28, 2024 23:35
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from 7cabd33 to daba970 Compare October 28, 2024 23:56
@alexfreska alexfreska changed the base branch from feat_actions_bottom to graphite-base/785 October 29, 2024 18:54
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from daba970 to b7d71b6 Compare October 29, 2024 18:55
@alexfreska alexfreska changed the base branch from graphite-base/785 to main October 29, 2024 18:55
@alexfreska alexfreska force-pushed the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch from b7d71b6 to 77069ed Compare October 29, 2024 18:55
Copy link
Contributor

@telestrial telestrial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may seem frictional to my last comment on multi-select about inviting users into the feature: if users must now click on the directory name exactly, is there an invitation to that? underlined or onHover underlined or something to that effect?

It may end up that some of the triggers/actions a user takes within this framework may need to be adjusted to feel more comfortable. Might be worth it to hit the discord when this lands and garner some feedback around what feels natural.

Copy link
Member Author

@telestrial agreed, I think after applying this feature to most of the tables we should review them all and make some refinements. I already made some changes (moving the selection from checkboxes to entire row) when adding to the file explorer because it felt more intuitive and consistent, but a few of the upcoming tables have other interacts when clicking a row that will need to be moved - so I think there will be some refinements to make once the first pass is done and have an inventory of all the interactions to support.
To answer your question about the discoverability, yes the text is underlined on hover. Another good addition may be double click to open a directory similar to the OS finder behaviour. Also matching system ctrl+select behaviour a little more closely. I will do some follow on improvements and once a version is out I agree the I'm sure users will have thoughts for us.

Copy link
Member Author

alexfreska commented Oct 30, 2024

Merge activity

  • Oct 30, 1:59 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 30, 1:59 PM EDT: A user merged this pull request with Graphite.

@alexfreska alexfreska merged commit 17b29cf into main Oct 30, 2024
36 of 37 checks passed
@alexfreska alexfreska deleted the feat_renterd_directory_mode_files_multiselect_and_batch_delete branch October 30, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants