Exclude pre-1.60 crates from workspace #1380
Conversation
Pre-1.60 crates can't be used in workspaces with other crates that use namespaced/weak features. This commit places all MSRV 1.60+ crates into `members` and moves the ones with earlier MSRVs into `exclude`.
tarcieri
force-pushed
the
exclude-pre-1.60-crates-from-workspace
branch
from
57b0862
to
1d3f075
Compare
tarcieri
force-pushed
the
exclude-pre-1.60-crates-from-workspace
branch
2 times, most recently
from
d13b1ec
to
85a0ccd
Compare
tarcieri
force-pushed
the
exclude-pre-1.60-crates-from-workspace
branch
from
85a0ccd
to
acc7ebb
Compare
|
Okay, that should hopefully make it green. This will result in |
| toolchain: nightly | ||
| - uses: dtolnay/rust-toolchain@nightly | ||
| - run: cargo update -Z minimal-versions | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| - uses: RustCrypto/actions/cargo-hack-install@master | ||
| - run: rm ../../Cargo.toml |
There was a problem hiding this comment.
Can't use the shared workflow due to this, FYI (it's nested a level deeper than usual)
There was a problem hiding this comment.
Maybe it's worth to move async-signature to the top level?
There was a problem hiding this comment.
Yeah, it would help with things like this. There's some open PRs though, so we'd need to get those merged first.
|
Going to go ahead and merge this so I can PR the |
| toolchain: nightly | ||
| - uses: dtolnay/rust-toolchain@nightly | ||
| - run: cargo update -Z minimal-versions | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| - uses: RustCrypto/actions/cargo-hack-install@master | ||
| - run: rm ../../Cargo.toml |
There was a problem hiding this comment.
Maybe it's worth to move async-signature to the top level?
Pre-1.60 crates can't be used in workspaces with other crates that use namespaced/weak features.
This commit places all MSRV 1.60+ crates into
membersand moves the ones with earlier MSRVs intoexclude.