Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Result from all generate_* methods #1379

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

newpavlov
Copy link
Member

No description provided.

@tarcieri
Copy link
Member

Beat you to it 😉 #1378

@tarcieri
Copy link
Member

@tarcieri
Copy link
Member

Of course it breaks right after I approve!

Ugh, yeah workspaces with mixed pre-and-post 1.60 crates aren't fun. FWIW I've put the other crates which use weak feature activation and/or namespacing in an exclude: https://github.com/RustCrypto/traits/blob/master/Cargo.toml#L15

I guess at some point we might consider bumping all of the crates in the workspace to at least 1.60 because otherwise it's an enormous pain.

@newpavlov newpavlov force-pushed the generate_result branch 2 times, most recently from 8d531f3 to 9cb8d1a Compare November 11, 2023 22:12
Cargo.toml Outdated Show resolved Hide resolved
@tarcieri
Copy link
Member

@newpavlov if you remove my suggested getrandom line, I'd be happy to take care of adding it back, which would also simplify this PR

@newpavlov
Copy link
Member Author

@tarcieri
It's probably better to simply update aead to use crypto-common v0.2.0-pre.

@tarcieri
Copy link
Member

@newpavlov you'll also have to update universal-hash which has the same problem.

I opened #1380 to swap how members and exclude are currently being used.

@newpavlov
Copy link
Member Author

@tarcieri
I am not sure why, but universal-hashes CI passes without issues.

@newpavlov
Copy link
Member Author

Duh... Updating aead to crypto-common v0.2 will be slightly more involved than I thought, so I will follow your recomendation and will remove the use of namespaced features.

@tarcieri
Copy link
Member

Aah, universal-hash is already using the rm ../Cargo.toml trick

@newpavlov newpavlov merged commit eb07d10 into master Nov 11, 2023
9 checks passed
@newpavlov newpavlov deleted the generate_result branch November 11, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants