Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sendMessage API has an updated signature in the ChromeSDK expecting extensionId, and options missing from the mock #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

sendMessage API has an updated signature in the ChromeSDK expecting extensionId, and options missing from the mock #9

wants to merge 4 commits into from

Commits on Jul 27, 2024

  1. Adjust sendMessage signature to match latest 

    Chrome has adjusted this signature so when this is called with an extensionId this mock fails an error 

TypeError: cb is not a function
    @rspitler-nudge
    rspitler-nudge authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    8b3da57 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Merge pull request #1 from rspitler-nudge/patch-1 

    Adjust sendMessage signature to match latest
    @rspitler-nudge
    rspitler-nudge authored Jul 28, 2024
    Configuration menu
    Copy the full SHA
    beef1e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Update tests to reflect new signature

    @rspitler-nudge
    rspitler-nudge committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f41b54e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from rspitler-nudge/patch-1 

    Update sendMessage signature to reflect modern Chrome SDK
    @rspitler-nudge
    rspitler-nudge authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    75b3ae1 View commit details
    Browse the repository at this point in the history