sendMessage API has an updated signature in the ChromeSDK expecting extensionId, and options missing from the mock #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome has adjusted this signature so when this is called with an extensionId this mock fails an error TypeError: cb is not a function
Adjust sendMessage signature to match latest
Update sendMessage signature to reflect modern Chrome SDK
RickyMarou
approved these changes
Sep 10, 2024
|
Thank you @rspitler-nudge and sorry for the delay. I'll merge this and publish a new version later this week. I definitely need to automate all this 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing parameters and updated the tests to reflect changes