-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analytical Jacobian for EdgeSE2PointXYBearing type #818
Add analytical Jacobian for EdgeSE2PointXYBearing type #818
Conversation
…larity in EdgeSE2PointXYBearing error function
for more information, see https://pre-commit.ci
…ts, increase tolerance in EdgeSE2PointXYBearing Jacobian unit test.
@RainerKuemmerle it looks like the Jacobian unit test was just failing due to a small difference between the numeric and analytical Jacobians. I think this error is actually being introduced by the numeric approach, as increasing the delta used when computing this from g2o/g2o/core/base_fixed_sized_edge.hpp Line 161 in de58780
(1/(x^2 + y^2) or atan2 .
I obviously don't want to globally change the numerical difference delta size to make this pass, but given the closeness of the results and workaround I'm confident my new code is correct, so don't really want to complicate the test to work around what appears to be an existing issue. I think the best route forward is to parametrise the tolerance in
|
evaluateJacobian
helper method to allow tests to specify a different Jacobian tolerance value