-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 78 new top down parameters for a partial retrofitted bes #79
Merged
FWuellhorst
merged 34 commits into
main
from
issue-78-New_top-down_parameters_for_a_partial_retrofitted_BES
Jul 16, 2024
Merged
Changes from 22 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
63cfd8a
NoRetrofit for hydraulic transfersystem
HvanderStok 6b6b963
temp example for partial retrofit
HvanderStok 3ed40a7
Add internal parameters to represent the first design of a subsystem
HvanderStok e8269b0
update internal design parameters
HvanderStok 7d70087
fix error
HvanderStok 6e3cf31
Merge remote-tracking branch 'origin/main' into issue-78-New_top-down…
HvanderStok 42da5f6
fix typos
HvanderStok b62988f
connect old_design parameters of of the hydraulic subsystems
HvanderStok 57631a5
rename design parameters
HvanderStok 544b60f
option to use old radiator design
HvanderStok e8fe28f
option to use complete old design for distribution
HvanderStok c2a6b08
option to use complete old design for generation
HvanderStok 34c10c8
add dp rad to res to allow different mass flows
HvanderStok ebab9a4
add default for old_design parameters
HvanderStok 9f20b8d
not needed
HvanderStok 79968b4
move use_old_design to subsystems which are using it
HvanderStok cfe8ac0
add documentation of parameterization
HvanderStok 61dbd0f
set use_old_design in subsystems to final
HvanderStok 87e4f5d
update documentation
HvanderStok d670df9
Merge branch 'main' into issue-78-New_top-down_parameters_for_a_parti…
FWuellhorst 3c9cd1e
CI message from ebc-aixlib-bot. Push new files with corrected html Sy…
FWuellhorst 8bb7809
Corrected HTML Code in branch correct_HTML_issue-78-New_top-down_para…
FWuellhorst 80d6afc
update ci tests
FWuellhorst 4497f37
rename example (and changes based on review in the last commit)
FWuellhorst 59cd3c7
changes based on review
FWuellhorst 814c73c
update all buildings records with new function of nominal heat load e…
FWuellhorst 5c8b53d
rm unused files and update usage of heaLoadFacGrd etc.
FWuellhorst 9cb3021
add simulate and plot scripts for new examples and specify roof area
FWuellhorst 864c098
CI message from ebc-aixlib-bot. Automatic push of CI with new regress…
FWuellhorst 5de51bf
fix tests by providing defaults
FWuellhorst 9842670
trigger update reference results for new heat load calculations. Also…
FWuellhorst 745a527
CI message from ebc-aixlib-bot. Automatic push of CI with new regress…
FWuellhorst 1c820f8
update reference results
FWuellhorst a4672cb
CI message from ebc-aixlib-bot. Automatic push of CI with new regress…
FWuellhorst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ HighOrderModel | |
ModelicaConferencePaper | ||
SolarThermalSystem | ||
TEASERHeatLoadCalculation | ||
PartialRetrofit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
mSup_flow_design
to avoid the if statements in the instances. I think these parameters may disappear anyway once I change the distribution layout, lets see.