-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 78 new top down parameters for a partial retrofitted bes #79
Issue 78 new top down parameters for a partial retrofitted bes #79
Conversation
…_parameters_for_a_partial_retrofitted_BES
dp is now allways dependent on the nominal mass flow and not the design mass flow in the radiator
In these subsystems the functionality is not fully implemented
…al_retrofitted_BES
Thank you for making a Pull Request to BESMod! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
…meters_for_a_partial_retrofitted_BES (#80)
@HvanderStok : The new more interactive CI is ready :) I will take a look at this PR in the next days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature looks really cool! I adjusted minor things (see comments and commits). Also, I added more building records with better names and automatic heat load calculation as this was long overdue and it was fitting for the new example. Once the CI passes we can merge this :)
@@ -1,7 +1,7 @@ | |||
within BESMod.Systems.Hydraulical.Generation; | |||
model HeatPumpAndGasBoilerParallel | |||
"Parallel connection of heat pump and gas boiler" | |||
extends BaseClasses.PartialHeatPumpAndGasBoiler; | |||
extends BaseClasses.PartialHeatPumpAndGasBoiler(final use_old_design); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the default to avoid unwanted behavior if we switch the default in the partial at some point
final QHC1_flow_nominal=Q_flow_nominal[1]*f_design[1], | ||
final mHC1_flow_nominal=mSup_flow_nominal[1], | ||
final QHC1_flow_nominal=Q_flow_design[1]*f_design[1], | ||
final mHC1_flow_nominal=if use_old_design[1] then mSupOld_flow_design[1] else mSup_flow_nominal[1], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added mSup_flow_design
to avoid the if statements in the instances. I think these parameters may disappear anyway once I change the distribution layout, lets see.
…ion reference files. Please pull the new files before push again. Plottet Results /issue-78-New_top-down_parameters_for_a_partial_retrofitted_BES/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/issue-78-New_top-down_parameters_for_a_partial_retrofitted_BES/charts |
…, perform OM check and simulate together with Dymola
Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/issue-78-New_top-down_parameters_for_a_partial_retrofitted_BES/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /issue-78-New_top-down_parameters_for_a_partial_retrofitted_BES/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/issue-78-New_top-down_parameters_for_a_partial_retrofitted_BES/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /issue-78-New_top-down_parameters_for_a_partial_retrofitted_BES/charts/
Closes #78