tools: fix shebang for static-test.sh #12239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change shebang in static-test.sh from `/bin/bash` to `/usr/bin/env bash` This fixes problems when `bash` is not available in standard location, but e.g. in `/usr/local/bin/` as on FreeBSD.
smlng
added
Area: build system
aabadie
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
ACK
Note that there are other places that could be updated as well:
git grep "/bin/bash"
dist/tools/has_minimal_version/has_minimal_version.sh:#! /bin/bash
dist/tools/openocd/openocd.sh:#!/bin/bash
dist/tools/packer/setup.sh:#!/bin/bash -eux
Binary file pkg/oonf_api/patches/0002-port-tests-to-riot.patch matches
|
yeah, I'm working my way through it - should I add fixes for the others here too? |
too late, sorry. But feel free to open a PR fixing the remaining ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Change shebang in static-test.sh from
/bin/bashto/usr/bin/env bashThis fixes problems when
bashis not available in standard location,but e.g. in
/usr/local/bin/as on FreeBSD.Testing procedure
run
make static-teston your favourite OS which should still work.Issues/PRs references
#3392