Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix shebang in scripts #12242

Merged
merged 3 commits into from
Sep 16, 2019
Merged

tools: fix shebang in scripts #12242

merged 3 commits into from
Sep 16, 2019

Conversation

smlng
Copy link
Member

@smlng smlng commented Sep 16, 2019

Contribution description

Changes shebang in all remaining tools scripts from /bin/bash to /usr/bin/env bash.
This fixes problems when bash is not available in its standard location, e.g. on non-Linux
OSes such as FreeBSD.

Testing procedure

Run scripts on your OS, they should still work as before.

Issues/PRs references

follow up on #12239
#3392

@smlng
tools: fix shebang in has_minimal_version.sh
277fbd8 
Change shebang in script from `/bin/bash` to `/usr/bin/env bash`,
which fixed problems when `bash` is not available in standard location,
e.g., on non-Linux OSes such as FreeBSD.
@smlng
tools: fix shebang in openocd.sh
364c831 
Change shebang in script from `/bin/bash` to `/usr/bin/env bash`,
which fixed problems when `bash` is not available in standard location,
e.g., on non-Linux OSes such as FreeBSD.
@smlng
tools: fix shebang in packer/setup.sh
9e87046 
Change shebang in script from `/bin/bash` to `/usr/bin/env bash`,
which fixed problems when `bash` is not available in standard location,
e.g., on non-Linux OSes such as FreeBSD.
@smlng smlng added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tools Area: Supplementary tools labels Sep 16, 2019
@smlng smlng requested review from miri64 and aabadie September 16, 2019 09:30
aabadie
aabadie approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenOCD still works. Murdock reports no issues when building packages using has_minimal_version.sh script.
Packer json file is broken on master so cannot really test but should be fine anyway.

ACK

@aabadie aabadie merged commit 0ae86d7 into RIOT-OS:master Sep 16, 2019
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
3 participants
@smlng @aabadie @kb2ma