add support for standard <video> and <audio> formats
#1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
changed the title
<video> and <audio> formats
3 tasks
thescientist13
commented
Feb 5, 2023
.gitattributes
Outdated
| *.flv binary | ||
| *.mp4 binary | ||
| *.ts binary |
There was a problem hiding this comment.
hmm, will this convert typescript files too? 🤔
|
|
||
| return new Response(body, { | ||
| headers: new Headers({ | ||
| 'Content-Type': `image/${contentType}` |
There was a problem hiding this comment.
Whoa... this is really wrong 😬
Wonder how it's still working though?? 🤨
thescientist13
force-pushed
the
release/0.28.0
branch
from
27a2440 to
1e02188
Compare
thescientist13
force-pushed
the
feature/issue-1038-standard-audio-and-video-formats
branch
from
25a277e to
7e6604b
Compare
|
So maybe I have been over thinking this or misinterpreting some of the data I read, but it seems like .mp4 and .3pg are both video (container) formats, so maybe we don't need any of this generic container format handling.
This would just leave .ogg then, which does seem to be a container format and seems like we can just use a generic content type instead of trying to "sniff" it out That said, the |
thescientist13
force-pushed
the
feature/issue-1038-standard-audio-and-video-formats
branch
from
58b06c0 to
7157728
Compare
thescientist13
deleted the
feature/issue-1038-standard-audio-and-video-formats
branch
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
* add support for standard video formats * fix content type in video response * restore content length header for Safari support * remove standard .ts video format support * adding audio resource support and adding test cases * misc refactor * refactor audio and video files according to better understanding of container formats * clean up TODO comment
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
* add support for standard video formats * fix content type in video response * restore content length header for Safari support * remove standard .ts video format support * adding audio resource support and adding test cases * misc refactor * refactor audio and video files according to better understanding of container formats * clean up TODO comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1038
Summary of Changes
<video>and<audio>formatsContent-Lengthheader which was needed by Safari (will make more robust as part handle merging additionalRequest/Responseinstance properties #1048)servecommandTODO
<audio>formatsbreakon first come, first serve 🤔Acceptheader?How to best handle Safari for generic media container formats?- solved through above solution?type=audio|video?https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/CreatingVideoforSafarioniPhone/CreatingVideoforSafarioniPhone.html#//apple_ref/doc/uid/TP40006514-SW6
Documentation / callout about asset handling on Safari- N / ARequest/Responseinstance properties #1048Error: read ECONNRESET at TCP.onStreamRead (node:internal/stream_base_commons:217:20)