break after first found resource match for dev server serve lifecycle #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
thescientist13
force-pushed
the
bug/dev-proxy-for-dev-server-returning-html
branch
from
ff8c313 to
87207f1
Compare
thescientist13
changed the title
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
seems like a regression from #1054 , where the
breakwas removed. Reproducible in AnalogStudiosRI/www.analogstudios.net#85(there's probably a little more than meet's the eye here but probably better to err on the side of caution and preserve existing behavior when it was not intended to be changed)
Summary of Changes
breakin serve resource lifecycle in dev server