fix the div 0 error of sparse_embedding #49948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Comment on lines
+790
to
+792
| if input.size == 0: | ||
| raise ValueError("input size should not be 0") | ||
|
|
There was a problem hiding this comment.
这个报错是哪里报错的？可以在C++端做检查吗？
There was a problem hiding this comment.
Traceback (most recent call last):
File "bug.py", line 6, in <module>
paddle.static.nn.sparse_embedding(input, [2097152, 2097152, 2097152, 2097152], padding_idx=2097152)
File "/home/work/wangying/paddlepaddle/pdpd_fuzz_protobuf/pdpd-env/clang_pd_fuzz_env/lib/python3.8/site-packages/paddle/fluid/contrib/layers/nn.py", line 1205, in sparse_embedding
w = helper.create_parameter(
File "/home/work/wangying/paddlepaddle/pdpd_fuzz_protobuf/pdpd-env/clang_pd_fuzz_env/lib/python3.8/site-packages/paddle/fluid/layer_helper_base.py", line 432, in create_parameter
return self.main_program.global_block().create_parameter(
File "/home/work/wangying/paddlepaddle/pdpd_fuzz_protobuf/pdpd-env/clang_pd_fuzz_env/lib/python3.8/site-packages/paddle/fluid/framework.py", line 3963, in create_parameter
initializer(param, self)
File "/home/work/wangying/paddlepaddle/pdpd_fuzz_protobuf/pdpd-env/clang_pd_fuzz_env/lib/python3.8/site-packages/paddle/fluid/initializer.py", line 72, in __call__
return self.forward(param, block)
File "/home/work/wangying/paddlepaddle/pdpd_fuzz_protobuf/pdpd-env/clang_pd_fuzz_env/lib/python3.8/site-packages/paddle/fluid/initializer.py", line 712, in forward
limit = math.sqrt(6.0 / float(fan_in + fan_out))
ZeroDivisionError: float division by zero
求指路一下c++端文件~
There was a problem hiding this comment.
啊，抱歉，我看了一下报错。这个是python端的错误。只能加在python端。
seemingwang
approved these changes
Feb 1, 2023
pangengzheng
pushed a commit
to pangengzheng/Paddle
that referenced
this pull request
Feb 2, 2023
* fix the div 0 error of sparse_embedding * add unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe