Skip to content

Commit

Permalink
fix the div 0 error of sparse_embedding (PaddlePaddle#49948)
Browse files Browse the repository at this point in the history
* fix the div 0 error of sparse_embedding

* add unittest
  • Loading branch information
Liyulingyue authored and pangengzheng committed Feb 2, 2023
1 parent 292ff27 commit c7c3575
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 0 deletions.
3 changes: 3 additions & 0 deletions python/paddle/fluid/contrib/layers/nn.py
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,9 @@ def sparse_embedding(
'paddle.static.nn.sparse_embedding',
)

if input.size == 0:
raise ValueError("input size should not be 0")

w = helper.create_parameter(
attr=helper.param_attr,
shape=size,
Expand Down
37 changes: 37 additions & 0 deletions python/paddle/fluid/tests/unittests/test_sparse_embedding_op.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import unittest

import paddle


class TestSparseEmbeddingAPIError(unittest.TestCase):
def test_errors(self):
with paddle.fluid.dygraph.guard():
# The size of input in sparse_embedding should not be 0.
def test_0_size():
input = paddle.to_tensor([], dtype='int64')
paddle.static.nn.sparse_embedding(
input,
[2097152, 2097152, 2097152, 2097152],
padding_idx=2097152,
)

self.assertRaises(ValueError, test_0_size)


if __name__ == '__main__':
paddle.enable_static()
unittest.main()

0 comments on commit c7c3575

Please sign in to comment.