Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry publishing attempts #750

Merged
merged 13 commits into from
Aug 10, 2023
Merged

Retry publishing attempts #750

merged 13 commits into from
Aug 10, 2023

Conversation

svevang
Copy link
Member

@svevang svevang commented Aug 8, 2023

closes #714

Sets up a retry mechanism that tests if the latest (most current) publishing pipeline has failed. If so, a new publishing publishing item is created and a new publishing pipeline is attempted.

See #665

@svevang svevang marked this pull request as ready for review August 9, 2023 14:40
# and until somthing akin to https://github.com/PRX/feeder.prx.org/issues/714 lands
# the RSS publishing is extracted from the publishing pipeline semantics.
# TODO: recombine the publishing invocations (RSS, Apple) once we have some retry guarantees
podcast.feeds.each { |feed| save_file(podcast, feed) }
Copy link
Member Author

@svevang svevang Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns the RSS publishing to it's previous place in the partitioned concurrency semantics.

So now:

  • Apple publishing and delivery will block RSS, for those podcasts with that configured.
  • Only one thread will be publishing RSS at a time (partitioned by podcast).

Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me

@svevang svevang merged commit c7f3897 into main Aug 10, 2023
1 check passed
@farski farski deleted the retry-publishing-attempts branch June 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry Publishing Pipelines
2 participants