-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry publishing attempts #750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svevang
commented
Aug 9, 2023
# and until somthing akin to https://github.com/PRX/feeder.prx.org/issues/714 lands | ||
# the RSS publishing is extracted from the publishing pipeline semantics. | ||
# TODO: recombine the publishing invocations (RSS, Apple) once we have some retry guarantees | ||
podcast.feeds.each { |feed| save_file(podcast, feed) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returns the RSS publishing to it's previous place in the partitioned concurrency semantics.
So now:
- Apple publishing and delivery will block RSS, for those podcasts with that configured.
- Only one thread will be publishing RSS at a time (partitioned by podcast).
cavis
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #714
Sets up a retry mechanism that tests if the latest (most current) publishing pipeline has failed. If so, a new publishing publishing item is created and a new publishing pipeline is attempted.
See #665