Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard for no current or scheduled publishing items #759

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Guard for no current or scheduled publishing items #759

merged 1 commit into from
Aug 11, 2023

Conversation

svevang
Copy link
Member

@svevang svevang commented Aug 11, 2023 •
edited
Loading

Bug fix for the cases where:

  • the job is started but there is no current publishing item to compare (which would itself be an error condition)
  • the in-flight jobs via Retry publishing attempts #750 may not have had a pub item supplied as top level params.

See #665

svevang
svevang commented Aug 11, 2023
View reviewed changes
app/models/publishing_pipeline_state.rb
@@ -127,6 +127,8 @@ def self.attempt!(podcast, perform_later: true)
else
PublishFeedJob.perform_now(podcast, latest_unfinished_item)
end

latest_unfinished_item
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to return a handle on the publishing item -> pipeline pair.

cavis
cavis approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me!

@svevang svevang merged commit c0429d6 into main Aug 11, 2023
1 check passed
@svevang svevang deleted the guard-for-nil-pub-items branch August 11, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavis cavis cavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svevang @cavis