Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podcasts guid, set by uuidv5, add to rss #1104

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

kookster
Copy link
Member

@kookster kookster commented Sep 29, 2024

fixes #1110

Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me. I do wonder if we shouldn't just add these to all existing podcasts.

db/schema.rb Outdated
t.string "owner_type"
t.integer "owner_id"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, couple of unrelated changes in here. Are you working off a prod backup?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it just changed the order of the columns, not the type or anything - is that a problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I was not working off a copy of prod when I ran these migrations.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem - it'll just flicker back the next time someone runs a migration locally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that is annoying, I fixed it

@@ -0,0 +1,6 @@
class AddGuidToPodcasts < ActiveRecord::Migration[7.2]
def change
add_column :podcasts, :guid, :string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to just generate these for all existing Podcasts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and we could do that at the console at any time, I just didn't force it in this PR

Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kookster kookster merged commit 4badbd7 into main Oct 9, 2024
3 checks passed
@kookster kookster deleted the feat/podcasts_guid branch October 9, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a guid to use for identifying a podcast
2 participants