Merge pull request #1104 from PRX/feat/podcasts_guid

Add podcasts guid, set by uuidv5, add to rss

app/models/podcast.rb

@@ -7,6 +7,9 @@ class Podcast < ApplicationRecord
   FEED_GETTERS = FEED_ATTRS.map { |s| [s, "#{s}_was".to_sym, "#{s}_changed?".to_sym] }.flatten
   FEED_SETTERS = FEED_ATTRS.map { |s| "#{s}=".to_sym }
 
+  # https://github.com/Podcastindex-org/podcast-namespace/blob/main/docs/1.0.md#guid
+  PODCAST_NAMESPACE = "ead4c236-bf58-58c6-a2c6-a6b28d128cb6".freeze
+
   include TextSanitizer
   include AdvisoryLocks
   include EmbedPlayerHelper
@@ -57,8 +60,18 @@ def self.by_prx_series(series)
     Podcast.find_by(prx_uri: series_uri)
   end
 
+  def set_guid!
+    update!(guid: guid) if set_guid
+  end
+
+  def set_guid
+    return unless public_url.present? && guid.blank?
+    self.guid = Digest::UUID.uuid_v5(PODCAST_NAMESPACE, public_url)
+  end
+
   def set_defaults
     self.explicit ||= "false"
+    set_guid
   end
 
   def default_feed

app/views/podcasts/show.rss.builder

@@ -102,6 +102,10 @@ xml.rss "xmlns:atom" => "http://www.w3.org/2005/Atom",
       xml.podcast :funding, "Support the Show!", "url" => @podcast.donation_url
     end
 
+    if @podcast.guid.present?
+      xml.podcast :guid, @podcast.guid
+    end
+
     @episodes.each_with_index do |ep, index|
       xml.item do
         xml.guid(ep.item_guid, isPermaLink: !!ep.is_perma_link)

db/migrate/20240928150204_add_guid_to_podcasts.rb

@@ -0,0 +1,6 @@
+class AddGuidToPodcasts < ActiveRecord::Migration[7.2]
+  def change
+    add_column :podcasts, :guid, :string
+    add_index :podcasts, :guid
+  end
+end

test/models/podcast_test.rb

@@ -16,6 +16,20 @@
     assert podcast.default_feed.private? == false
     assert podcast.default_feed.slug.nil?
     assert podcast.default_feed.file_name == Feed::DEFAULT_FILE_NAME
+    assert podcast.public_feed.present?
+    assert podcast.public_feed == podcast.default_feed
+  end
+
+  it "can set a guid on create or update" do
+    assert podcast.public_url == "http://feeds.feedburner.com/thornmorris"
+    assert podcast.guid == "95ebfb22-0002-5f78-a7aa-5acb5ac7daa9"
+    podcast.update_column(:guid, nil)
+    assert !podcast.guid.present?
+    podcast.set_guid
+    assert podcast.guid == "95ebfb22-0002-5f78-a7aa-5acb5ac7daa9"
+    podcast.update_column(:guid, nil)
+    podcast.set_guid!
+    assert podcast.guid == "95ebfb22-0002-5f78-a7aa-5acb5ac7daa9"
   end
 
   it "is episodic or serial" do