Use defaults instead of null in IborRateSwapLegConvention #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milenorf
changed the title
jodastephen
approved these changes
Dec 18, 2023
|
I actually changed the approach. The defaulting is now only for the stub convention. |
vaibhavkrishnakumar
approved these changes
Dec 18, 2023
sagiruthvik
pushed a commit
to SolumXplain/solum-xplain-opengamma-strata
that referenced
this pull request
Nov 13, 2024
…2622) * PROD-29409: default stub convention to SI * PROD-29409: use getters everywhere * default only stub convention * small copy paste fix * another copy paste fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking the getters in the toLeg() method will use defaults if the property is null.
E.g. instead of stub rate being null it will be defaulted to smart initial