Use defaults instead of null in IborRateSwapLegConvention (OpenGamma#…

…2622) * PROD-29409: default stub convention to SI * PROD-29409: use getters everywhere * default only stub convention * small copy paste fix * another copy paste fix
SolumXplain · Nov 13, 2024 · a63df5a · a63df5a
1 parent 261336c
commit a63df5a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/...duct/src/main/java/com/opengamma/strata/product/swap/type/FixedRateSwapLegConvention.java b/...duct/src/main/java/com/opengamma/strata/product/swap/type/FixedRateSwapLegConvention.java
@@ -344,7 +344,7 @@ public RateCalculationSwapLeg toLeg(
             .businessDayAdjustment(accrualBusinessDayAdjustment)
             .startDateBusinessDayAdjustment(startDateBusinessDayAdjustment)
             .endDateBusinessDayAdjustment(endDateBusinessDayAdjustment)
-            .stubConvention(stubConvention)
+            .stubConvention(getStubConvention())
             .rollConvention(rollConvention)
             .build())
         .paymentSchedule(PaymentSchedule.builder()

diff --git a/...oduct/src/main/java/com/opengamma/strata/product/swap/type/IborRateSwapLegConvention.java b/...oduct/src/main/java/com/opengamma/strata/product/swap/type/IborRateSwapLegConvention.java
@@ -498,7 +498,7 @@ public RateCalculationSwapLeg toLeg(
             .businessDayAdjustment(getAccrualBusinessDayAdjustment())
             .startDateBusinessDayAdjustment(startDateBusinessDayAdjustment)
             .endDateBusinessDayAdjustment(endDateBusinessDayAdjustment)
-            .stubConvention(stubConvention)
+            .stubConvention(getStubConvention())
             .rollConvention(rollConvention)
             .build())
         .paymentSchedule(PaymentSchedule.builder()

diff --git a/...t/src/test/java/com/opengamma/strata/product/swap/type/IborRateSwapLegConventionTest.java b/...t/src/test/java/com/opengamma/strata/product/swap/type/IborRateSwapLegConventionTest.java
@@ -16,6 +16,7 @@
 import static com.opengamma.strata.basics.schedule.Frequency.P3M;
 import static com.opengamma.strata.basics.schedule.Frequency.P6M;
 import static com.opengamma.strata.basics.schedule.StubConvention.LONG_INITIAL;
+import static com.opengamma.strata.basics.schedule.StubConvention.SMART_INITIAL;
 import static com.opengamma.strata.collect.TestHelper.assertSerialization;
 import static com.opengamma.strata.collect.TestHelper.coverBeanEquals;
 import static com.opengamma.strata.collect.TestHelper.coverImmutableBean;
@@ -152,6 +153,7 @@ public void test_toLeg() {
             .startDate(startDate)
             .endDate(endDate)
             .businessDayAdjustment(BDA_MOD_FOLLOW)
+            .stubConvention(SMART_INITIAL)
             .build())
         .paymentSchedule(PaymentSchedule.builder()
             .paymentFrequency(P3M)
@@ -178,6 +180,7 @@ public void test_toLeg_withSpread() {
             .startDate(startDate)
             .endDate(endDate)
             .businessDayAdjustment(BDA_MOD_FOLLOW)
+            .stubConvention(SMART_INITIAL)
             .build())
         .paymentSchedule(PaymentSchedule.builder()
             .paymentFrequency(P3M)