Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HEATCR and HEATCRT to props #3410

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

totto82
Copy link
Member

@totto82 totto82 commented Feb 23, 2023

The simulator supports HEATCR and HEATCRT but they where missing from the field prosps.

@totto82
Copy link
Member Author

totto82 commented Feb 23, 2023

jenkins build this please

@atgeirr atgeirr merged commit 60437b9 into OPM:master Feb 24, 2023
@OPMUSER
Copy link
Contributor

OPMUSER commented Feb 28, 2023

@atgeirr This does not fix the exception in issue #3411, we still get:

Program threw an exception: EclProblem::updateCompositionChangeLimits_()) failed:Invalid thermal conductivity approach: 0

The issue is that we do not check if all the require data for the Thermal model have been entered in the deck, if a particular data item is missing then the simulator throws an exception.

@atgeirr
Copy link
Member

atgeirr commented Feb 28, 2023

This does not fix the exception in issue #3411

I think it was not claimed that it would. In any case, do not close the issue until fixed. Will you work on the fix, or should someone else implement it? I think you or @totto82 probably know best which keywords need to go together, I imagine it is complicated but perhaps I am wrong?

@OPMUSER
Copy link
Contributor

OPMUSER commented Mar 1, 2023

I think it was not claimed that it would. In any case, do not close the issue until fixed. Will you work on the fix, or should someone else implement it? I think you or @totto82 probably know best which keywords need to go together, I imagine it is complicated but perhaps I am wrong?

I think @totto82 is better place to writing the checking code. Rather than checking that the Thermal model has been correctly defined, I think we should just implement checks as errors crop up. So for #3411 we need to check that thermal rock fluid parameters have been fully defined, that is to define the thermal rock fluid conductivity:

  1. Either use the THCONR keyword to define the combined rock and fluid conductivity, and optionally the THCONSF keyword, or
  2. By specifying the rock and fluid conductivities individually using the THCROCK, THCOIL, THCGAS, and THCWATER keywords.

I'll add a note to the manual in the GRID section explaining the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants