Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CO2STORE + THERMAL case #903

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Add CO2STORE + THERMAL case #903

merged 3 commits into from
Aug 30, 2023

Conversation

goncalvesmachadoc
Copy link
Contributor

No description provided.

@totto82
Copy link
Member

totto82 commented Feb 23, 2023

Thanks for the model. I am able to run this in Flow after removing some compositional keywords and fixing some missing issues. See OPM/opm-common#3410 I also added HEATCRT to the deck. Is the temperature dependence supposed to be neglected? Currently Flow fails if HEATCR is given but not HEATCRT.

@totto82 totto82 mentioned this pull request Feb 23, 2023
Merged
@bska
Copy link
Member

bska commented Mar 9, 2023

@goncalvesmachadoc: Do you expect to make further changes to this test case? If not, we should probably try to get the model into the main repository.

@goncalvesmachadoc
Copy link
Contributor Author

@totto82 and I are still planning on modifying it. We need to see which keywords we will comment out, and what we want to do about compositional keywords. Probably keep it, but ignore them. The same for #902 .

@bska
Copy link
Member

bska commented Mar 10, 2023

We need to see which keywords we will comment out, and what we want to do about compositional keywords. Probably keep it, but ignore them. The same for #902 .

Noted. Thanks a lot for the update!

@goncalvesmachadoc goncalvesmachadoc mentioned this pull request Mar 16, 2023
Merged
@goncalvesmachadoc
Copy link
Contributor Author

This case is ready for review. It has a few modifications to be able to run with OPM.

bska
bska approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I'll merge into master.

@bska bska merged commit a8e5bfe into master Aug 30, 2023
@bska bska deleted the goncalvesmachadoc-testcases-1 branch August 30, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bska bska bska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goncalvesmachadoc @totto82 @bska