Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]base_tier_validation_report: attempt to fix ci #733

Closed
wants to merge 1 commit into from
Closed

[FIX]base_tier_validation_report: attempt to fix ci #733

wants to merge 1 commit into from

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Oct 22, 2023 •
edited
Loading

Fixes #734

@OCA-git-bot
Copy link
Contributor

Hi @kittiu,
some modules you are maintaining are being modified, check this out!

@bosd bosd force-pushed the 15.0-fix-tier_validation_report branch 3 times, most recently from b6fb0f4 to b04b476 Compare October 23, 2023 06:56
This was referenced Oct 23, 2023
Closed
Closed
@bosd bosd force-pushed the 15.0-fix-tier_validation_report branch from b04b476 to 7776a33 Compare October 23, 2023 11:24
@bosd bosd marked this pull request as ready for review October 23, 2023 11:29
@bosd
Copy link
Contributor Author

bosd commented Oct 23, 2023 •
edited
Loading

@LoisRForgeFlow Seems fixed now 😃
Hope we can quickly hotpatch this one in..
Do you have super powers here?

@Dranyel-Bosd
Can you please review?

@bosd bosd mentioned this pull request Oct 23, 2023
Closed
@bosd bosd force-pushed the 15.0-fix-tier_validation_report branch from 7776a33 to 6bf1bd7 Compare October 23, 2023 13:23
Dranyel-Bosd
Dranyel-Bosd approved these changes Oct 23, 2023
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, tests are green so okay for me

@bosd bosd mentioned this pull request Oct 24, 2023
Open
@LoisRForgeFlow
Copy link
Contributor

As I mentioned in the issue, the CI is already fixed, therefore I think this PR is not needed.

@pedrobaeza pedrobaeza closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bosd @OCA-git-bot @LoisRForgeFlow @Dranyel-Bosd @pedrobaeza