[15.0][IMP]base_tier_validation: only post notifications to reciepients

[bosd]

Before this PR there where double tier review notifications when used in combination with tier_validation_waiting.

One of the messages has no recepients:

After this PR:
Only one notification gets posted.
(The one adressed to the requested reviewer)

[OCA-git-bot]

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

[LoisRForgeFlow]

@bosd something is wrong in the tests, can you have a look?

[bosd]

@bosd something is wrong in the tests, can you have a look?

@LoisRForgeFlow I noticed.
I'm working on it right now: #733

Yet it is a bit tricky. As I cannot replicate it on my local system.
Do you have any ideas?

[LoisRForgeFlow]

@bosd something is wrong in the tests, can you have a look?

@LoisRForgeFlow I noticed. I'm working on it right now: #733

Yet it is a bit tricky. As I cannot replicate it on my local system. Do you have any ideas?

Not really, I cannot reproduce it locally either...

[Dranyel-Bosd]

functionally review 👍

[bofiltd]

LGTM

[bosd]

Why does the @OCA-git-bot not attach the ready to merge label?

[LoisRForgeFlow]

Hi

I have just reviewed this PR, sorry for the delay.

I do not agree with this fix:

1. When you restart a validation, and request again, you will get no message now in the chatter.

2. You are trying to fix a problem in the interaction with base_tier_validation_waiting, however this module is not even available in version 15.0.

[bosd]

Thanks for the review..

1. When you restart a validation, and request again, you will get no message now in the chatter.

Can you check if the new message after restarting the validation is actually sent out to someone?
(Assuming that it is a message without a recepeint) Maybe we can solve this in another way.

2. You are trying to fix a problem in the interaction with base_tier_validation_waiting, however this module is not even available in version 15.0.

It is not yet merged in V15, but there is a PR in #638

The tier validation waiting module really adds some usefull features for sequential review.
But it also changes the base module drastically which makes it hard to test/maintain.
I've proposed to merge it into the base base_tier_validation module.
tracked in: #787 (comment)
Can you please provide some feedback on that idea there?

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.