[14.0][IMP] queue_job: automatically update dependent jobs when state changes manually #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- an explicit flush is needed or child jobs won't be updated - no need to forward port, this was fixed already in 16.0+
|
Hi @guewen, |
amh-mw
reviewed
Aug 1, 2024
| @@ -308,13 +308,16 @@ def _change_job_state(self, state, result=None): | |||
| if state == DONE: | |||
| job_.set_done(result=result) | |||
| job_.store() | |||
| record.env["queue.job"].flush() | |||
There was a problem hiding this comment.
Why is this flush necessary? This isn't the code path that was changed.
amh-mw
approved these changes
Aug 6, 2024
simahawk
approved these changes
Aug 6, 2024
|
This PR has the |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at c5552d5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
If a user explicitly cancels a job, he expects its child jobs to be canceled as well;
However if a job fails, child jobs will stay in WAIT_DEPENDENCIES state; an action is expected from user to fix it and job might succeed after being re-queued
Note
FIXcommit, it was fixed already as part of migration to 16.0+ (here)