[18.0][MIG] queue_job: Migrate to 18.0 #692

thienvh332 · 2024-10-07T09:53:56Z

Ported PRs

Changes

Cleaned TODO tags
Refactor the JobSerialized field on top of odoo.fields.Json
- Result

>>> self.env.cr.execute("SELECT column_name, data_type FROM information_schema.columns WHERE table_name = 'queue_job' AND column_name = 'kwargs';")
>>> self.env.cr.fetchall()
[('kwargs', 'jsonb')]

Example for searching:

>>> self.env.cr.execute("SELECT kwargs->>'a' FROM queue_job WHERE kwargs ? 'a'")
>>> self.env.cr.dictfetchall()
[{'?column?': 'abc'}, {'?column?': 'abc'}]

The float_time widget shows hours seconds, we only want seconds. The widget had been removed on the form view, but not on the tree view.

Use case: * you have a root channel per scope/app (eg: root.edi) * you have several sub channels (eg: root.edi.ubl.sales, root.edi.gs1.delivery) * you want to configure capacity only for the main channel "root.edi" Before this change, the channel manager falls back on root channel. However, if you have a specific parent channel configured it sounds a good idea to use it.

Contributing since a while... :)

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-15.0/queue-15.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-15-0/queue-15-0-queue_job/

test_queue_job will create channels root.sub and root.sub.sub, so the tests doing the same thing will fail with a unique constraint error.

When displayed in a tab, the widget show the nodes offset, the d3 network is probably confused by the size or visibility of its canvas. Install a listener on tabs to trigger a fit() on the network.

A graph of jobs always share the same graph_uuid, which can be used to group jobs, but is also a faster way to find all the jobs of the graph. Then we can use the dependencies field to build the whole graph from the pre-selection of jobs.

Currently translated at 100.0% (12 of 12 strings) Translation: queue-17.0/queue-17.0-test_queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-17-0/queue-17-0-test_queue_job/zh_CN/

Use the current company to trigger the job (+ add related tests) [14.0][FIX] queu_job: allowed_company_ids => use with_company(...) Fill allowed_company_ids from context with the job's company instead of every allowed companies of the user. Because most of the time, a job is related to only one company. And adding every allowed companies of the user into the context may load some unexpected records (during search for example). Because standards ir.rule use ['|',('company_id','=',False),('company_id', 'in', company_ids)] and this 'company_ids' is filled with every allowed companies from the context.

OCA#348 added support for randomized retry intervals. Configuration of randomized retry intervals is not possible due to the formatting checks not being updated. This should fix it.

- an explicit flush is needed or child jobs won't be updated - no need to forward port, this was fixed already in 16.0+

As the 'queue_job__no_delay' context key is the valid one to use, don't raise warnings during tests, but log it as information level.

sbidoul · 2024-10-11T08:14:49Z

@thienvh332 please don't change the behaviour based on test_enabled. Better use self.assertLogs to trap the log and test that it actually logged what was expected. See for example: OCA/server-tools@7d2e3d8

thienvh332 · 2024-10-11T09:27:58Z

@thienvh332 please don't change the behaviour based on test_enabled. Better use self.assertLogs to trap the log and test that it actually logged what was expected. See for example: OCA/server-tools@7d2e3d8

Hi @sbidoul
I think you are right, I tried the update but it didn't work for me. Could you help me see what I am missing?

thienvh332 · 2024-10-14T10:56:25Z

As commented in unittest, I am not able to control the printing of WARNING. So I will revert to the original handling. If you guys have any suggestions to handle it I will fix it.

OCA-git-bot · 2024-10-14T11:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sbidoul · 2024-10-14T11:05:16Z

The problem is we don't see what you tried anymore, so it's difficult to help.

thienvh332 · 2024-10-15T03:27:39Z

Hi @sbidoul , indeed I should have pushed a fixup commit instead of force-pushing

So here is what happened:
- the .assertLogs was trapping the log as expected when calling node.__del__ explicitely
- but python was still garbage collecting the node after the test, so an additional warning was emitted
To fix it, I now explicitly run the garbage collection with gc

Thanks for your help

sbidoul · 2024-10-15T06:02:22Z

@thienvh332 looks good, thanks!

simahawk · 2024-10-15T13:01:23Z

/ocabot merge nobump

OCA-git-bot · 2024-10-15T13:01:32Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-692-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2024-10-15T13:06:39Z

Congratulations, your PR was merged at 4b8b0fe. Thanks a lot for contributing to OCA. ❤️

mmequignon

A few remarks, LG overall

mmequignon · 2024-10-15T13:11:15Z

test_queue_job/tests/test_delayable.py

@@ -279,20 +282,23 @@ def test_delayable_group_of_chain(self):
        )

    def test_log_not_delayed(self):
-        logger_name = "odoo.addons.queue_job"
-        with self.assertLogs(logger_name, level="WARN") as test:
+        with self.assertLogs(level=logging.WARNING) as test:


Any WARNING log would be catched here, we should keep the logger filter.

mmequignon · 2024-10-15T13:13:33Z

test_queue_job/tests/test_job_auto_delay.py

-            result = (
-                self.env["test.queue.job"]
-                .with_context(_job_force_sync=True)
-                .delay_me(1, kwarg=2)
-            )


why aren't we keeping this _job_force_sync context key in the test_auto_delay_force_sync test method ?

Hi @mmequignon ,

Simone introduced that standardization in 16.0 ([16.0] queue_job: unify no delay option #521). It should have been dropped as part of 17.0 migration but wasn't.

So it's dropped in 18.0

simahawk and others added 30 commits October 7, 2024 16:52

queue_job: add hook to customize stored values

aba9a15

queue_job: migration step to store exception data

069b6f6

Fix display on exec_time on tree view as seconds

f3b9c83

The float_time widget shows hours seconds, we only want seconds. The widget had been removed on the form view, but not on the tree view.

[IMP] queue_job: black, isort, prettier

99e0e8c

Forward migration scripts from OCA#309 OCA#328

9543fea

queue_job: store exception name and message

922a626

[FIX] queue_job: Migrations raising errors with OpenUpgrade

88885f5

[IMP] queue_job: Add cancelled state to queue.job

bffa80d

[IMP] queue_job: tests for wizards

6dc7b34

[IMP] queue_job: use a widget in eta field in queue job tree view

103a4bf

queue_job: update contributors

465ddff

Contributing since a while... :)

[UPD] Update queue_job.pot

0ff5ee7

[UPD] README.rst

6340b2d

Update translation files

d7b90e9

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-15.0/queue-15.0-queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-15-0/queue-15-0-queue_job/

Store dependencies

064b41a

Add wait dependencies state

24a0288

Enqueue waiting jobs when parent jobs are done

9bb0d17

Optimize and make enqueue of waiting jobs more robust

9a96d04

Adapt views for state wait_dependencies

498eec9

Add API for Delayables

dae8fde

Fix tests failing when test_queue_job is installed

e6c904d

test_queue_job will create channels root.sub and root.sub.sub, so the tests doing the same thing will fail with a unique constraint error.

Add widget to show job dependencies on UI

5156f04

Show the dependency widget in a tab

4ad5010

When displayed in a tab, the widget show the nodes offset, the d3 network is probably confused by the size or visibility of its canvas. Install a listener on tabs to trigger a fit() on the network.

Add documentation on 'base' model public methods

6db198a

Improve loading of dependencies using batch read

75d31dd

Use Delayable in DelayableRecordset

f0698bd

Add documentation

84cf1a0

Add a graph UUID

1f73c7e

A graph of jobs always share the same graph_uuid, which can be used to group jobs, but is also a faster way to find all the jobs of the graph. Then we can use the dependencies field to build the whole graph from the pre-selection of jobs.

Hide some technical fields

6178a3a

OCA-git-bot and others added 8 commits October 11, 2024 14:59

[BOT] post-merge updates

77157c2

Translated using Weblate (Chinese (Simplified) (zh_CN))

5537e6f

Currently translated at 100.0% (12 of 12 strings) Translation: queue-17.0/queue-17.0-test_queue_job Translate-URL: https://translation.odoo-community.org/projects/queue-17-0/queue-17-0-test_queue_job/zh_CN/

Update test with proper way to pass company to job

35f23af

queue_job: fix retry format with tuple values

2941c11

OCA#348 added support for randomized retry intervals. Configuration of randomized retry intervals is not possible due to the formatting checks not being updated. This should fix it.

[FIX] queue_job: missing flush

531227d

- an explicit flush is needed or child jobs won't be updated - no need to forward port, this was fixed already in 16.0+

[IMP] queue_job: Cancel child jobs when the parent is cancelled

ec1c4c0

[IMP] queue_job: Don't raise a warning for valid context

eb6c5dd

As the 'queue_job__no_delay' context key is the valid one to use, don't raise warnings during tests, but log it as information level.

thienvh332 force-pushed the 18.0-mig-queue_job branch from 191a454 to d308edc Compare October 11, 2024 08:04

thienvh332 force-pushed the 18.0-mig-queue_job branch from d308edc to 0447d9a Compare October 11, 2024 08:38

thienvh332 force-pushed the 18.0-mig-queue_job branch from 0447d9a to c062b72 Compare October 14, 2024 10:48

OCA-git-bot added the ready to merge label Oct 14, 2024

[MIG] test_queue_job: Migration to 18.0

bb4b6f6

thienvh332 force-pushed the 18.0-mig-queue_job branch from c062b72 to bb4b6f6 Compare October 15, 2024 03:06

OCA-git-bot added the bot is merging ⏳ label Oct 15, 2024

OCA-git-bot merged commit 8281c2b into OCA:18.0 Oct 15, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 15, 2024

mmequignon reviewed Oct 15, 2024

View reviewed changes

xaviedoanhduy mentioned this pull request Oct 21, 2024

[18.0][MIG] base_import_async: Migration to 18.0 #699

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] queue_job: Migrate to 18.0 #692

[18.0][MIG] queue_job: Migrate to 18.0 #692

thienvh332 commented Oct 7, 2024 •

edited

Loading

sbidoul commented Oct 11, 2024

thienvh332 commented Oct 11, 2024

thienvh332 commented Oct 14, 2024

OCA-git-bot commented Oct 14, 2024

sbidoul commented Oct 14, 2024

thienvh332 commented Oct 15, 2024

sbidoul commented Oct 15, 2024

simahawk commented Oct 15, 2024

OCA-git-bot commented Oct 15, 2024

OCA-git-bot commented Oct 15, 2024

mmequignon left a comment

mmequignon Oct 15, 2024

mmequignon Oct 15, 2024

thienvh332 Oct 16, 2024 •

edited

Loading

[18.0][MIG] queue_job: Migrate to 18.0 #692

[18.0][MIG] queue_job: Migrate to 18.0 #692

Conversation

thienvh332 commented Oct 7, 2024 • edited Loading

Ported PRs

Changes

sbidoul commented Oct 11, 2024

thienvh332 commented Oct 11, 2024

thienvh332 commented Oct 14, 2024

OCA-git-bot commented Oct 14, 2024

sbidoul commented Oct 14, 2024

thienvh332 commented Oct 15, 2024

sbidoul commented Oct 15, 2024

simahawk commented Oct 15, 2024

OCA-git-bot commented Oct 15, 2024

OCA-git-bot commented Oct 15, 2024

mmequignon left a comment

Choose a reason for hiding this comment

mmequignon Oct 15, 2024

Choose a reason for hiding this comment

mmequignon Oct 15, 2024

Choose a reason for hiding this comment

thienvh332 Oct 16, 2024 • edited Loading

Choose a reason for hiding this comment

thienvh332 commented Oct 7, 2024 •

edited

Loading

thienvh332 Oct 16, 2024 •

edited

Loading