Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] dms_field: Use own service instead of using dialog service of component #348

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[16.0][FIX] dms_field: Use own service instead of using dialog service of component #348

merged 1 commit into from
Jun 20, 2024

Conversation

CarlosRoca13
Copy link

cc @Tecnativa TT48507

This commit solves the problems reported on #347

Steps to reproduce the problem:

  1. Go to Documents > Documents
  2. Select a file and press on eye button to preview it
  3. Close preview
  4. Select a folder
  5. Press on buttons Create a folder, Create a file or Open the folder

An error about dialog.add is not a function will be thrown

ping @pedrobaeza @victoralmau @hitrosol

@CarlosRoca13
[FIX] dms_field: Use own service instead of using dialog service of c…
d97a364 
…omponent

This commit solves the problems reported on OCA#347

Steps to reproduce the problem:

1. Go to Documents > Documents
2. Select a file and press on eye button to preview it
3. Close preview
4. Select a folder
5. Press on buttons Create a folder, Create a file or Open the folder

An error about dialog.add is not a function will be thrown
@pedrobaeza pedrobaeza changed the title [FIX] dms_field: Use own service instead of using dialog service of component [16.0][FIX] dms_field: Use own service instead of using dialog service of component Jun 20, 2024
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 20, 2024
@pedrobaeza pedrobaeza linked an issue Jun 20, 2024 that may be closed by this pull request
error when one click the icon in dms_file #347
Closed
pedrobaeza
pedrobaeza approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@hitrosol
Copy link

Thanks for taking care my report.

I try to access the runboat of this PR, but it seems take a long time it is ready. Not only for this repo but also for others.
Hopefully there will be fixing in the runboat server...

@CarlosRoca13
Copy link
Author

@pedrobaeza it seems that the command is having no effect

@pedrobaeza
Copy link
Member

@sbidoul can you please check if ocabot is stuck, as today any operation with it has started?

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not start, because command git fetch origin pull/348/head:tmp-pr-348 failed with output:

fatal: unable to access 'https://github.com/OCA/dms/': gnutls_handshake() failed: The TLS connection was non-properly terminated.

@pedrobaeza
Copy link
Member

@hitrosol runboat is now ready

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-348-by-pedrobaeza-bump-patch, awaiting test results.

hitrosol
hitrosol approved these changes Jun 20, 2024
View reviewed changes
Copy link

@hitrosol hitrosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I have tested functionally on runboat.

@OCA-git-bot OCA-git-bot merged commit 405ab31 into OCA:16.0 Jun 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7812452. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-MIG-dms_field branch June 20, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@hitrosol hitrosol hitrosol approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

error when one click the icon in dms_file
5 participants
@CarlosRoca13 @hitrosol @pedrobaeza @OCA-git-bot @victoralmau