Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove docs from 16.0 branch #3853

Merged
merged 1 commit into from
May 6, 2023

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented May 5, 2023

  • remove all docs folder

  • remove all docsource folder, except coverage file of the current version. (15 -> 16)

  • simplify pre-commit stuff, removing exception regarding docs / docsource folders.

  • minor changes in main README.md file

Consequency :

  • the 16.0 branch is a more "classic" module folder, with less exception
  • save CI execution with a reduction of about 20%. (from 13 minutes to 10 minutes)

Note : once validated, I'll do the same for recent branches with new modules design. (14 / 15)

@legalsylvain legalsylvain marked this pull request as ready for review May 5, 2023 19:25
@legalsylvain
Copy link
Contributor Author

@pedrobaeza
Copy link
Member

I'm seeing one problem: any merge in 16.0 branch won't trigger a new documentation build. That was one of the reasons for not splitting the documentation branch.

@legalsylvain
Copy link
Contributor Author

Hi. Thanks for your reviews !

I'm seeing one problem: any merge in 16.0 branch won't trigger a new documentation build. That was one of the reasons for not splitting the documentation branch.

Yes, the problem was raised in the original topic and I answered here :

#3702 (comment)

A PoC is available, feel free to take a look on it.

I'll do a PR against the "master" branch. (16.0 for the time being) to add this file :
https://github.com/grap/openupgrade-doc-test/blob/master/.github/workflows/documentation-commit-schedule.yml
(frequency to decide).

Note : that is unrelated to that PR. For now, the github workflow present in the 16.0 branch and removed by this PR doesn't deploy on oca.github.io/openupgrade

@legalsylvain
Copy link
Contributor Author

Note : i checked again github doc, and instead of using cron, we can use path filter. Pseudo workflow :

Pull :
Path = modules150-160.rst
Branch = 16.0

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

This will even save more CI !

Anyway, @pedrobaeza, unrelated to this PR. Is this one OK for you ?

@pedrobaeza pedrobaeza added this to the 16.0 milestone May 6, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants