Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated commits of Matesaktesak 3d mouse implementation #226

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

apm963
Copy link

@apm963 apm963 commented Aug 11, 2020

This is a consolidation of PRs #190 #191, #192, #193 by @Matesaktesak as a result of this discussion. I combined these using the merge --ff strategy. I have not made any changes to the code contained in these PRs. Testing will be needed before release.

@apm963 apm963 mentioned this pull request Aug 11, 2020
src/HID-APIs/D3MouseAPI.h Outdated Show resolved Hide resolved
src/HID-APIs/D3MouseAPI.h Outdated Show resolved Hide resolved
Copy link
Author

@apm963 apm963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few typos in dimensional vars

src/HID-APIs/D3MouseAPI.hpp Outdated Show resolved Hide resolved
src/HID-APIs/D3MouseAPI.hpp Outdated Show resolved Hide resolved
@NicoHood
Copy link
Owner

NicoHood commented Aug 15, 2020

Thanks for working on this again :-)
Please report, once you have tested it. Also please fix the suggested comment from @gdsports (thanks!)

@NicoHood
Copy link
Owner

Ping

@apm963
Copy link
Author

apm963 commented Jul 17, 2021

@NicoHood I apologize for the delay. I have committed the suggestions from @gdsports as well as my original comments on this consolidated PR.

I am unable to personally test this week as my setup has changed significantly. Is this something that someone else can jump in and assist with? Otherwise I will try to set aside some time to get set back up for C++ development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants