Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/anson/228 #229

Closed
wants to merge 2 commits into from
Closed

Bug/anson/228 #229

wants to merge 2 commits into from

Commits on Sep 27, 2024

  1. Fixes #201 and #228 

    Created new helper function `getImageUrl` to return the correct image uri based on whether it is offline or online.
    @PohAnson
    PohAnson committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    38410ba View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Edit to getImageUrl logic 

    Accounts for the possibility that the picture was previously saved on cloudinary when it goes offline. In that case retrieve from cloudinary.

If is online setup, it is assumed that the offline computer is not running, so the image cannot be retrieved either ways.
    @PohAnson
    PohAnson committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3493596 View commit details
    Browse the repository at this point in the history