Bug/anson/228 #229
Closed
Bug/anson/228 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PohAnson
force-pushed
the
bug/anson/228
branch
from
9b05280
to
38410ba
Compare
Accounts for the possibility that the picture was previously saved on cloudinary when it goes offline. In that case retrieve from cloudinary. If is online setup, it is assumed that the offline computer is not running, so the image cannot be retrieved either ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201 and #228
Created a helper function
getImageUrlthat returns the url based on whether it is online or offline. Refactored all the image url to use this function.