Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues encountered during pytest #166

Open
wants to merge 9 commits into
base: fastsim-3
Choose a base branch
from
Open

Fix issues encountered during pytest #166

wants to merge 9 commits into from

Commits on Nov 14, 2024

  1. Load demo tests using sys.executable 

    Previously, the string "python" was being used
in the subprocess call. However, this did not always
do the right thing when, for example, the demo tests
are being called within a virutal environment using
pytest. By using sys.executable, we use the same
python interpreter used to run pytest and/or the test_demos.py
file.
    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e33ae3e View commit details
    Browse the repository at this point in the history

  2. Switch back to Pandas DataFrame prior to printing. 

    On Windows (and perhaps other platforms), we were running
into an encoding error when the Polars DataFrame was being
asked to print (i.e., being converted to a string). As a
work-around, we convert the Polars DataFrame to a Pandas
DataFrame prior to printing and this works without issue.
    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7842832 View commit details
    Browse the repository at this point in the history

  3. Add example build-and-test CI workflow

    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    18b20f5 View commit details
    Browse the repository at this point in the history

  4. Update workflow to trigger on push

    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d943d0c View commit details
    Browse the repository at this point in the history

  5. Correct syntax error.

    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5e6d35c View commit details
    Browse the repository at this point in the history

  6. Add pyarrow dependency. 

    This is required on (at least) Ubuntu for the
Polars DataFrame to Pandas DataFrame conversion.
    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    676f912 View commit details
    Browse the repository at this point in the history

  7. Ensure that development deps are installed (needed to run tests)

    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f0a45a3 View commit details
    Browse the repository at this point in the history

  8. Skipping speed tests. 

    These did not consistently pass on the CI.

From Chad Baker:
... the speedup failing tests can be ignored for now.
We need to come up with a better way of testing the speed
up relative to fastsim-2, but I’m not sure that's an
urgent problem.
    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4abf4a9 View commit details
    Browse the repository at this point in the history

  9. Remove pyarrow as a dependency. It is in the dev deps already

    Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f831879 View commit details
    Browse the repository at this point in the history