Fix issues encountered during pytest #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 14, 2024 12:08
Previously, the string "python" was being used in the subprocess call. However, this did not always do the right thing when, for example, the demo tests are being called within a virutal environment using pytest. By using sys.executable, we use the same python interpreter used to run pytest and/or the test_demos.py file.
On Windows (and perhaps other platforms), we were running into an encoding error when the Polars DataFrame was being asked to print (i.e., being converted to a string). As a work-around, we convert the Polars DataFrame to a Pandas DataFrame prior to printing and this works without issue.
added 5 commits
November 14, 2024 14:13
This is required on (at least) Ubuntu for the Polars DataFrame to Pandas DataFrame conversion.
These did not consistently pass on the CI. From Chad Baker: ... the speedup failing tests can be ignored for now. We need to come up with a better way of testing the speed up relative to fastsim-2, but I’m not sure that's an urgent problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues encountered during running
pytest -von Windows:Additionally, this version adds a CI workflow file to build and test the application.