Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve cyme reader logging, power factor handling, doc strings #400

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

improve cyme reader logging, power factor handling, doc strings #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
266bb2e
cyme reader: improve warning msgs for bad load values
nlaws-camus Aug 26, 2022
547a896
handle zero power factor in cyme reader for loads
nlaws-camus Aug 26, 2022
7d968fa
handle negative power factor in cyme reader
nlaws-camus Aug 26, 2022
156a868
rm debug msg in cyme reader
nlaws-camus Aug 26, 2022
9a72c99
cyme reader clarify parser_helper role
nlaws-camus Aug 26, 2022
0972ee8
improve warning messages from cyme reader
nlaws-camus Aug 26, 2022
e52d28c
add Winding.base_voltage
nlaws-camus Sep 14, 2022
6faea6d
add cyme reader test for load.nominal_voltage [FAILS]
nlaws-camus Oct 5, 2022
ac439fd
cyme reader: improve warning msgs for bad load values
nlaws-camus Aug 26, 2022
718e16f
handle zero power factor in cyme reader for loads
nlaws-camus Aug 26, 2022
58ba413
handle negative power factor in cyme reader
nlaws-camus Aug 26, 2022
b70e800
rm debug msg in cyme reader
nlaws-camus Aug 26, 2022
10f9b95
cyme reader clarify parser_helper role
nlaws-camus Aug 26, 2022
631650e
improve warning messages from cyme reader
nlaws-camus Aug 26, 2022
326b82a
add cyme reader test for load.nominal_voltage [FAILS]
nlaws-camus Oct 5, 2022
a1bc47b
Merge branch 'nlaws/cyme-reader' of https://github.com/nlaws-camus/di…
nlaws-camus Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ditto/models/winding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ class Winding(DiTToHasTraits):
nominal_voltage = Float(
help="""The nominal voltage of the transformer winding""", default_value=None
)
base_voltage = Float(
help="""The voltage basis for per unit calculations""", default_value=None
)
voltage_limit = Float(
help="""The maximum voltage allowed on the PT secondary.""", default_value=None
)
Expand Down
Loading