improve cyme reader logging, power factor handling, doc strings #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure why this is here, just printing cable sectionID
- cannot parse a list of objects though it was taking a obj_list as input; - it would only parse the first value in the list; - now it takes in a string instead of list of string - also improved notes/documentation
came across some transformers in CYME that have actual voltages set to something different than nominal. CYME has base voltages in TRANSFORMER SETTINGS (e.g. `primarybasevoltage`) and actual voltages in TRANSFORMER (e.g. `kvllprim`). The latter are currently set to Winding.nominal_voltage.
add same test to opendss reader, which passes
nlaws-camus
commented
Oct 5, 2022
| @@ -44,6 +45,28 @@ def test_cyme_reader(): | |||
| # TODO: Log properly | |||
| print(">Cyme model {model} parsed.\n".format(model=model)) | |||
|
|
|||
| if model == "ieee_13node": | |||
| """ | |||
| test load base voltage values | |||
There was a problem hiding this comment.
@tarekelgindy this is the load nominal voltage issue that I mentioned in the cyme reader. perhaps we should add tests for comparing opendss voltage values between a IEEE13 model read from cyme and a IEEE13 model read from opendss?
There was a problem hiding this comment.
Note that this test is failing because of a bug in cyme reader I believe.
not sure why this is here, just printing cable sectionID
- cannot parse a list of objects though it was taking a obj_list as input; - it would only parse the first value in the list; - now it takes in a string instead of list of string - also improved notes/documentation
add same test to opendss reader, which passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes
Improvements
parser_helperwas taking in a list of object names but only parsing the first item in the list (by design), so I made that list argument a single argument