-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDES project updates #447
Draft
hdunham
wants to merge
171
commits into
develop
Choose a base branch
from
multiple-elec-stor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
LDES project updates #447
Changes from all commits
Commits
Show all changes
171 commits
Select commit
Hold shift + click to select a range
5b04b56
Add per kW and per kWh installed capacity based battery O&M
lixiangk1 8627a8d
Add O&M financials to ElectricStorage results
lixiangk1 564365f
Add battery self discharge, defaulted to zero
lixiangk1 ae61517
Merge branch 'develop' into battery_om
lixiangk1 3e1a3d6
Merge branch 'develop' into battery_om
lixiangk1 5542a5d
Merge branch 'develop' into battery_om
lixiangk1 c2f3c5d
Add battery self-discharge to MPC model
lixiangk1 37e3083
Enable BESS O&M for multiple sites
lixiangk1 9ee741e
Add code comments and tests for battery O&M and self-discharge; updat…
lixiangk1 e2a0cac
Update code comments
lixiangk1 66e848a
Merge branch 'develop' into battery_om
adfarth 53014bc
Merge branch 'develop' into battery_om
lixiangk1 14f3ced
Update storage self-discharge input from daily to per timestep
lixiangk1 b67bdcc
Add duration constraint
lixiangk1 7c339a1
Fix ldes constraint, add duration input
lixiangk1 ac253e5
Allow battery wholesale export, preliminary implementation
toddleif d66297f
Added optional constraint for requiring start and end battery charge …
toddleif cdc4da8
Set initial SOC = final SOC for BESS and allow REopt to decide value,…
lixiangk1 0fbdb98
rename self discharge input for consistency
hdunham 58b6769
Update CHANGELOG.md
hdunham 0e739ab
simplify WHL_benefit expression
hdunham 25f310f
correct self discharge term
hdunham 4f987ac
simplify soc expressions
hdunham 1f4ebe9
picking nits
hdunham e6f7cc4
only use 1 bin to prevent simultaneous charge/discharge
hdunham 8f6ff4f
change binBattCharging definition too
hdunham 515a684
dont need 0 index for binBattCharging
hdunham fbd6d46
rm unnecessary loop
hdunham 9954293
rm manifest in test directory
hdunham 019b6bc
fix extra ] typo
hdunham 371a76b
fix variable def syntax
hdunham b84e917
make storage om test more comprehensive
hdunham 5ce036a
consolidate storage om and self discharge tests
hdunham ad46c89
more concise
hdunham ce5977a
uncomment tests
hdunham 51a7ff9
rm self discharge test now dupe
hdunham 1d3181f
Update CHANGELOG.md
hdunham d6b9b6e
comment out battery charge/discharge binary
hdunham 2b07689
comment out added battery power constraint
hdunham c6ff686
comment out dvStorageToGrid
hdunham 0b1618b
Revert "comment out dvStorageToGrid"
hdunham eb6ed96
comment out dvStorageToGrid in WHL_benefit expression
hdunham c273972
Revert "comment out added battery power constraint"
hdunham 3a8834a
Revert "comment out battery charge/discharge binary"
hdunham 134adb6
add battery max_kw to bigM_hourly_load
hdunham 5db75ae
change to bigM_hourly_load_plus_battery_power where used
hdunham 0f13d77
add b index to dvStorageToGrid
hdunham 7d2694e
add dvStorageToGrid to mpc model
hdunham 31e912b
is_ldes and duration -> fixed_duration
hdunham 0d37b7c
account for fixed_duration not in MPCElectricStorage
hdunham 84293bd
account for require_start_and_end_charge_to_be_equal not in MPCElectr…
hdunham 3bd6e24
add allow_simultaneous_charge_discharge input to ElectricStorage
hdunham d0b4671
move def of binBattCharging to be with rest of variable defs
hdunham f34f44c
missing comma
hdunham 0336a2d
only prevent simultaneous battery charge/discharge when that input is…
hdunham 300c95e
add allow_simultaneous_charge_discharge to MPCElectricStorage
hdunham 9f4df44
rm dvStorageToGrid from general storage discharge power constraint
hdunham 5f64284
make dvStorageToGrid multinode compat
hdunham 4cf25f3
Merge branch 'develop' into ldes-analysis-fixed-duration
lixiangk1 6212406
add more export incentive and om tax/period combos to results
hdunham a79ae20
Merge branch 'develop' into battery_om
lixiangk1 5eea67e
Add capacity-based self-discharge, update tests
lixiangk1 8ad69fd
add can_export_to_grid ElectricStorage input
hdunham 88cc28e
Revert "add can_export_to_grid ElectricStorage input"
hdunham f04b60d
add can_export_to_grid ElectricStorage input
hdunham c069122
fix storage export to zero if can_export_to_grid=false
hdunham 1c85716
rename require_start_and_end_charge_to_be_equal to optimize_soc_init_…
hdunham 0f2f246
still fix init and final soc for non elec storage and elec storage wh…
hdunham 5c512b5
remove final soc constraint
hdunham 9bde839
add can_export_to_grid to test inputs
hdunham bb90447
improve log msg
hdunham 81927a2
use _n where missing in wind results processing
hdunham 7edb8a3
round initial_capital_cost in wind and pv results
hdunham a885836
add initial_capital_cost output to steam turbine
hdunham 80e7f6c
add initial_capital_cost output to generator
hdunham 1428684
add initial_capital_cost output to electric heater
hdunham e8032d1
add initial_capital_cost output to chp
hdunham d13ff0b
add initial_capital_cost output to boiler
hdunham 586b4c5
correct some initial_capital_cost calcs
hdunham 8f42464
add initial_capital_cost output to thermal storage
hdunham f642462
Update CHANGELOG.md
hdunham b0a24c5
add initial_capital_cost output to absorption chiller
hdunham 305075d
remove initial_capital_cost from chp results for now
hdunham dd13655
make b arg required in degradation functions
hdunham 2960b23
add name field to ElectricStorage
hdunham c9115a5
loop elec stor, don't hardcode "ElectricStorage" (bigM_hourly_load_pl…
hdunham 5f2ceb6
use b arg don't hardcode "ElectricStorage"
hdunham 710f2f5
handle ElectricStorage being a list of dicts
hdunham 1d3bce0
loop elec stor, don't hardcode "ElectricStorage" (steam turbine results)
hdunham b69edbf
(gen results) loop elec stor, don't hardcode "ElectricStorage"
hdunham 949bcb8
(utility results) loop elec stor, don't hardcode "ElectricStorage"
hdunham 293fcd7
(chp results) loop elec stor, don't hardcode "ElectricStorage"
hdunham 1de9ca6
(elec stor results) use b arg don't hardcode "ElectricStorage"
hdunham 793e8d7
(mpc/model.jl) don't hardcode "ElectricStorage"
hdunham e3a7656
correct error msg
hdunham 3ce3e32
error in ERP if multiple elec stor
hdunham dcda12a
in ERP use d["ElectricStorage"]["name"] not "ElectricStorage" hardcoded
hdunham 970bd2b
(outagesim) handle elec stor name and error if multiple
hdunham febc367
Revert "(outagesim) handle elec stor name and error if multiple"
hdunham 8fb61ee
Revert "in ERP use d["ElectricStorage"]["name"] not "ElectricStorage"…
hdunham b1b8dd7
Revert "error in ERP if multiple elec stor"
hdunham 1e06aac
Revert "correct error msg"
hdunham 9d0c564
Revert "(mpc/model.jl) don't hardcode "ElectricStorage""
hdunham 12889a5
Revert "(elec stor results) use b arg don't hardcode "ElectricStorage""
hdunham 63ab4eb
Revert "(chp results) loop elec stor, don't hardcode "ElectricStorage""
hdunham c4f138a
Revert "(utility results) loop elec stor, don't hardcode "ElectricSto…
hdunham 10d3264
Revert "(gen results) loop elec stor, don't hardcode "ElectricStorage""
hdunham 34179ac
Revert "loop elec stor, don't hardcode "ElectricStorage" (steam turbi…
hdunham fc44e06
Revert "handle ElectricStorage being a list of dicts"
hdunham 7161f6e
Revert "use b arg don't hardcode "ElectricStorage""
hdunham 6139428
Revert "loop elec stor, don't hardcode "ElectricStorage" (bigM_hourly…
hdunham ac5a954
Revert "add name field to ElectricStorage"
hdunham 29657c0
Revert "make b arg required in degradation functions"
hdunham aec28ca
(proforma) handle elec stor name and error if multiple
hdunham c978da3
make outage stor constraints take b arg
hdunham 38efed4
pass b arg into MG elec stor constraints
hdunham a800d82
organize_multiple_elec_stor_results
hdunham 29dda76
function name typo correction
hdunham 3f9892c
create ElectricStorage struct before getting name so always there
hdunham e6f7f6b
correct var name
hdunham 7dde72b
safe get ElectricStorage name because only included if multiple
hdunham fd206ab
add multiple elec stor test
hdunham 52922e4
fix edit to constrain_degradation_variables
hdunham 457acd1
debugging
hdunham 9d5e3cd
cast as Real[] so sum of empty [] doesn't error
hdunham d3d90e0
rm debugging
hdunham a8f12a3
Merge branch 'develop' into ldes-analysis-fixed-duration
lixiangk1 3a577e4
Merge branch 'develop' into battery_om
lixiangk1 e674a1b
Merge branch 'ldes-analysis-fixed-duration' into multiple-elec-stor
hdunham 53f7b57
fix auto merge errors 1
hdunham 7d53be8
correct changelog merge
hdunham 95aa65e
fix auto merge errors 2
hdunham ccb6412
fix auto merge errors 3
hdunham cc346fb
fix auto merge errors 4
hdunham 8bbcd38
fix auto merge errors 5
hdunham fec2f30
fix auto merge errors 6
hdunham e7f8d16
add Logging to test project
hdunham a138d27
add b index to binBattCharging (new set approach)
hdunham a4dd661
Revert "add b index to binBattCharging (new set approach)"
hdunham 06e85f0
Merge branch 'prevent-simul-charge-discharge' into multiple-elec-stor
hdunham dae181d
merge fix
hdunham 728dfcb
rm binBattCharging
hdunham 3d9eb90
update Multiple Electric Storage to include more edge cases
hdunham a896afb
uncomment tests
hdunham 6921855
Merge branch 'ldes-analysis-fixed-duration' into multiple-elec-stor
hdunham 275a088
Merge branch 'prevent-simul-charge-discharge' into multiple-elec-stor
hdunham c2de716
fix missing end from merge
hdunham b5840df
rm allow_simultaneous_charge_discharge
hdunham dc3ba22
Revert "Update expected Solar dataset test from updated NSRDB"
hdunham fef2dec
rm debugging write to file
hdunham a4f5bf2
Update CHANGELOG.md
hdunham 45f2bf7
Merge branch 'develop' into multiple-elec-stor
hdunham 20ee7e4
Merge branch 'prevent-simul-charge-discharge' into multiple-elec-stor
hdunham 9659f0a
Merge branch 'develop' into multiple-elec-stor
hdunham d1f84f9
trigger tests
hdunham 300755b
make storage_to_grid_series_kw array not denseaxisarray
hdunham ab1d65b
fix typo
hdunham 1ff7a31
Update thermal decay variables to match electric storage self-discharge
lixiangk1 d42ae3a
Merge branch 'develop' into battery_om
lixiangk1 78793c0
Remove extra minus sign
lixiangk1 eaa270f
Merge branch 'battery_om' into multiple-elec-stor
lixiangk1 b80f465
Fix typo
lixiangk1 d4979c2
fix degradation merge
hdunham a10fb6b
add self discharge terms to elec no simultaneous charge/discharge con…
hdunham db87859
fix changelog merge
hdunham 59a4586
fix changelog merge
hdunham 6aa56d4
align changelog with multiple-elec-stor
hdunham 7f92425
Merge branch 'battery_om' into multiple-elec-stor
hdunham 22c909c
Merge branch 'develop' into multiple-elec-stor
hdunham c847aa0
rm fixed_duration constraint
hdunham dc729d8
fix conversion error
hdunham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdunham I'm seeing some discrepancies and overlap between this branch and:
ElectricStorage
O&M changes by @lixiangk1. Is that PR or this PR more up-to-date for those changes?ElectricStorage
min, max duration inputs by @atpham88, which is an alternative way to implement the fixed_duration changes in this branch.I think it makes sense to merge each of those branches above into this PR. What do you think?