Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDES project updates #447

Draft
wants to merge 171 commits into
base: develop
Choose a base branch
from
Draft

LDES project updates #447

wants to merge 171 commits into from

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Oct 8, 2024

Develop LDES

Added

  • Added inputs om_cost_per_kw and om_cost_per_kwh to ElectricStorage for modeling capacity-based O&M
  • Added outputs lifecycle_om_cost_after_tax and year_one_om_cost_before_tax to ElectricStorage
  • Added new input self_discharge_fraction_per_timestep to ElectricStorage for modeling battery self-discharge
  • Added input option can_export_to_grid (defaults to false) to ElectricStorage and decision variable dvStorageToGrid
  • Added input fixed_duration to ElectricStorage, which fixes the ratio between size_kw and size_kwh in the optimized solution if provided
  • Added input option optimize_soc_init_fraction (defaults to false) to ElectricStorage, which makes the optimization choose the inital SOC (equal to final SOC) instead of using soc_init_fraction. The initial SOC is also constrained to equal the final SOC, which eliminates the "free energy" issue. We currently do not fix SOC when soc_init_fraction is used because this has caused infeasibility.
  • Added output initial_capital_cost to all techs
  • Added ability to model multiple ElectricStorage at once. Inputs are provided as a list of dict under the ElectricStorage key and outputs are similarly formatted. This mirrors the existing multiple PV implementation. This functionality is not yet implemented for MPC scenarios.

Fixed

  • Added missing outputs lifecycle_export_benefit_before_tax and year_one_export_benefit_after_tax to ElectricTariff
  • Add missing output year_one_om_cost_before_tax to PV

lixiangk1 and others added 30 commits January 23, 2024 13:17
@hdunham hdunham requested a review from adfarth October 8, 2024 19:48
@@ -23,6 +25,35 @@ Classify the change according to the following categories:
### Deprecated
### Removed

## Develop LDES
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdunham I'm seeing some discrepancies and overlap between this branch and:

I think it makes sense to merge each of those branches above into this PR. What do you think?

@hdunham hdunham marked this pull request as draft October 15, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants