-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDES project updates #447
Draft
hdunham
wants to merge
171
commits into
develop
Choose a base branch
from
multiple-elec-stor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
LDES project updates #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add outputs for PV/wind
This reverts commit d25ba18.
adfarth
reviewed
Oct 11, 2024
@@ -23,6 +25,35 @@ Classify the change according to the following categories: | |||
### Deprecated | |||
### Removed | |||
|
|||
## Develop LDES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdunham I'm seeing some discrepancies and overlap between this branch and:
- https://github.com/NREL/REopt.jl/pull/354/files -- for the
ElectricStorage
O&M changes by @lixiangk1. Is that PR or this PR more up-to-date for those changes? - Limit battery storage duration #332 -- for the
ElectricStorage
min, max duration inputs by @atpham88, which is an alternative way to implement the fixed_duration changes in this branch.
I think it makes sense to merge each of those branches above into this PR. What do you think?
when multiple pvs or elec stors and only their Real inputs provided, was trying to push name string to a Dict{String,Any}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Develop LDES
Added
ElectricStorage
for modeling capacity-based O&MElectricStorage
ElectricStorage
for modeling battery self-dischargeElectricStorage
and decision variable dvStorageToGridElectricStorage
, which fixes the ratio between size_kw and size_kwh in the optimized solution if providedElectricStorage
, which makes the optimization choose the inital SOC (equal to final SOC) instead of using soc_init_fraction. The initial SOC is also constrained to equal the final SOC, which eliminates the "free energy" issue. We currently do not fix SOC when soc_init_fraction is used because this has caused infeasibility.ElectricStorage
at once. Inputs are provided as a list of dict under theElectricStorage
key and outputs are similarly formatted. This mirrors the existing multiplePV
implementation. This functionality is not yet implemented for MPC scenarios.Fixed
ElectricTariff
PV