-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHP to proforma metrics, add thermal BAU outputs #281
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
130842c
Update financial.jl
rathod-b 7644871
add tests for GHP LCC calculations
rathod-b 3b0771a
Update test_with_xpress.jl
rathod-b 3e03425
Update test_with_xpress.jl
rathod-b 340007a
Update test_with_xpress.jl
rathod-b 95fa8c2
Update test_with_xpress.jl
rathod-b c1f3121
Update proforma.jl
rathod-b e94d581
Improve explicitness of default coupling
Bill-Becker ea4bf06
Add ExistingBoiler result year_one_fuel_cost_before_tax_bau
Bill-Becker d737fa1
Add ExistingBoiler annual_thermal_production_mmbtu_bau result
Bill-Becker a6fd624
update proforma and results
rathod-b 4bff14f
Add more BAU outputs
Bill-Becker 7e2d5ce
Merge branch 'ghp_results_updates' of https://github.com/NREL/REopt.j…
Bill-Becker 39ad4a3
Add BAU lcc fuel cost
Bill-Becker 1540bc4
Remove some erroneous commas in tests
Bill-Becker 5822077
Handle Central GHP WWHP in update_ghp_metrics with different sizes
Bill-Becker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rathod-b I updated this to handle Central GHP "WWHP" with the two different heat pump sizes. I just made
new_kw
== average of two sizes as a workaround even though they should be handled separately. Punt on that!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!