Add GHP to proforma metrics, add thermal BAU outputs #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathod-b
commented
Oct 2, 2023
test/test_with_xpress.jl
Outdated
| calc_om_cost_after_tax = calculated_om_costs*(1-inputs.s.financial.owner_tax_rate_fraction) | ||
| @test results["Financial"]["lifecycle_om_costs_after_tax"] = calc_om_cost_after_tax atol=0.1 | ||
|
|
||
| @test r["lifecycle_capital_costs_plus_om_after_tax"] = results["Financial"]["initial_capital_costs"]*0.7 + calc_om_cost_after_tax atol=5 |
There was a problem hiding this comment.
For some reason, this and subsequent tests arent adding up. There is a difference of ~54,000 between the two numbers. Any idea what could be causing this?
Bill-Becker
approved these changes
Oct 3, 2023
This doesn't actually change behavior, but it describes better how this line in scenario.jl is coupled to the default can_serve_dhw (not ideal, they'd have to be changed together)
…into ghp_results_updates
Bill-Becker
reviewed
Oct 4, 2023
| @@ -359,6 +364,72 @@ function update_metrics(m::Metrics, p::REoptInputs, tech::AbstractTech, tech_nam | |||
| nothing | |||
| end | |||
|
|
|||
| function update_ghp_metrics(m::REopt.Metrics, p::REoptInputs, tech::REopt.AbstractTech, tech_name::String, results::Dict, third_party::Bool) | |||
There was a problem hiding this comment.
@rathod-b I updated this to handle Central GHP "WWHP" with the two different heat pump sizes. I just made new_kw == average of two sizes as a workaround even though they should be handled separately. Punt on that!
Bill-Becker
changed the title
rathod-b
pushed a commit
that referenced
this pull request
Mar 8, 2024
Add GHP to proforma metrics, add thermal BAU outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.