v0.32.4 #241
Merged
v0.32.4 #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PV size changed by 2% which aligns with change in PV output with update to v8
For both production factor (PV) and ambient air temperature data (GHP)
…actor at the same time This avoids an extra call of PVWatts with GHP and PV
This allows for assigning pv.production_factor_series when calling PVWatts for GHP, to avoid a extra PVWatts calls later
The get_ambient_temperature() function is now combined into that call.
The energy_rates array was 8784 instead of skipping the leap year day like the rest of the code does This was throwing errors when checking the length of the input like wholesale_rate (8760) with energy_rate from URDB (8784 in this case)
Update to PVWatts v8 from v6
Hot fix for rates with non standard units
Update test values due to PVWatts v8 Update
Generator installed_cost_per_kw default
hdunham
reviewed
Jul 26, 2023
hdunham
reviewed
Jul 26, 2023
hdunham
reviewed
Jul 26, 2023
| @@ -82,7 +82,7 @@ | |||
| If `azimuth` is not provided, then it is set to 180 if the site is in the northern hemisphere and 0 if in the southern hemisphere. | |||
|
|
|||
| """ | |||
| struct PV <: AbstractTech | |||
| mutable struct PV <: AbstractTech | |||
There was a problem hiding this comment.
fine for now but for performance we should be trying to avoid making structs mutable
There was a problem hiding this comment.
@hdunham do you want to make an issue for this? This was a change Bill made in order to allow for assigning pv.production_factor_series when calling PVWatts for GHP, to avoid a extra PVWatts calls later.
hdunham
reviewed
Jul 26, 2023
rathod-b
pushed a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PRs:
fix for rates with non standard units #236
Update to PVWatts v8 from v6 #233
Update test values due to PVWatts v8 Update #242
Generator installed_cost_per_kw default #238