-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cambium Grid Climate Emissions and Updated AVERT #235
Changes from 64 commits
5744ba1
b821ea9
14cba62
9388d7d
7bef890
e3ac9ff
40e58d0
cb2470b
2b054fb
8b69e81
cd3a60e
08af697
d341165
cd7a519
9e6f97b
1b9812f
79cfc21
cbad810
81ed59a
c584dfa
819d498
1bce45d
e9f20d6
4bd8190
2b58410
49d577c
80090de
7c105a8
a297a63
c4314aa
8192e3f
d96c42d
0216621
5f07394
1f27cce
d75e8b2
5919f06
768d90b
58aace0
bfa13b1
cd69445
5de415a
8354222
a5e28ea
64a78b9
daffa88
1c8fe55
928ef25
0d46d93
9ac6e24
74a10c9
c472e3f
bc374ec
59a1270
cf12bea
f38e904
30530fe
85f3308
bd1b3a4
349c378
bcc34f5
c04979e
434f108
0c59472
569301c
31c2c2b
5e3c480
77833eb
e74ed3e
919d859
556b37b
d7be87a
70cd420
f9399c8
ab3ae64
5fa7896
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,8 @@ export | |
get_steam_turbine_defaults_size_class, | ||
simulated_load, | ||
get_absorption_chiller_defaults, | ||
emissions_profiles, | ||
avert_emissions_profiles, | ||
cambium_emissions_profile, | ||
easiur_data, | ||
get_existing_chiller_default_cop | ||
|
||
|
@@ -72,10 +73,10 @@ const FUEL_DEFAULTS = Dict( | |
"diesel_oil"=>0.0 | ||
), | ||
"emissions_factor_lb_CO2_per_mmbtu" => Dict( | ||
"natural_gas"=>116.9, | ||
"landfill_bio_gas"=>114.8, | ||
"propane"=>138.6, | ||
"diesel_oil"=>163.1 | ||
"natural_gas"=>117.03, | ||
"landfill_bio_gas"=>115.38, | ||
"propane"=>139.16, | ||
"diesel_oil"=>163.61 | ||
Comment on lines
75
to
+79
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These numbers match the PR description but regarding the migration to CO2-equivalent emissions: the costs in the objective function for NOx here is health-related only like the two non-GHG pollutants (SO2 and PM25), is that correct? That would ensure we aren't double-counting if NOx is included in the CO2e calculation as it's an indirect GHG. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zolanaj Yes, the NOx cost equation only accounts for health-related costs that are a direct result of the emissions (rather than health outcomes from climate change). However, isn't CO2e a combination of CO2, CH4, and N2O (which is not a subset of NOx emissions?)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adfarth Yes, that matches my understanding of CO2e calculation too. I think the net-positive global warming impact is NOx triggering reactions in the atmosphere to make ozone at certain concentrations, and only molecules that directly trap heat are considered in the CO2e calculation. Sounds like we are on the same page here, thanks for confirming! |
||
), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The other potentially obnoxious comment: is it worth changing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As discussed we will bring this up in our next dev meeting. Will involve a breaking change to inputs and outputs |
||
"emissions_factor_lb_NOx_per_mmbtu" => Dict( | ||
"natural_gas"=>0.09139, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that this change should be added to the Changelog entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in ab3ae64