v23.2.0-IOFreeze: Coil and Unitary systems changes #4958

jmarrec · 2023-09-04T10:26:31Z

Pull request overview

This is the main dish of the upgrade to v23.2.0 IOFreeze.

Add the new XXX Fan Power Per Volume Flow Rate 2017/2023 for coils
- Coil:Cooling:TwoSpeed
- Coil:Cooling:DX:VariableSpeed:SpeedData, Coil:Heating:DX:VariableSpeed:SpeedData
Coil Latent stuff:
- Move some values from unitary systems to child object: maximum Cycling Rate, Heat Pump Time Constant, Fan Delay Time => get moved as fields for cooling coil or as the "Part Load Fraction Correlation Curve" in case of heating
- Parent unitary systems:
  - AirLoopHVAC:UnitarySystem
  - ZoneHVAC:WaterToAirHeatPump
- Child coils:
  - Coil:Cooling:WaterToAirHeatPump:EquationFit, Coil:Heating:WaterToAirHeatPump:EquationFit
  - Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit, (Coil:Heating:WaterToAirHeatPump:VariableSpeedEquationFit is unchanged actually)
  - Coil:Cooling:DX:VariableSpeed

Add the "Crankcase Heater Capacity Function of Temperature Curve Name" for all coils, see

OpenStudio/src/osversion/VersionTranslator.cpp

Lines 7887 to 7898 in 879a518

    
           constexpr std::array<std::pair<std::string_view, size_t>, 10> crankcaseCoilWithIndex{{ 
        
             {"OS:Coil:Cooling:DX:CurveFit:Performance", 3}, 
        
             {"OS:Coil:Cooling:DX:SingleSpeed", 27}, 
        
             {"OS:Coil:Cooling:DX:TwoStageWithHumidityControlMode", 6}, 
        
             {"OS:Coil:Cooling:DX:MultiSpeed", 13}, 
        
             {"OS:Coil:Heating:DX:SingleSpeed", 19}, 
        
             {"OS:Coil:Heating:DX:MultiSpeed", 8}, 
        
             {"OS:Coil:Heating:DX:VariableSpeed", 13}, 
        
             {"OS:Coil:WaterHeating:AirToWaterHeatPump", 20}, 
        
             {"OS:Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed", 18}, 
        
             {"OS:Coil:WaterHeating:AirToWaterHeatPump:Wrapped", 13}, 
        
           }};

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

…(Two Speed and VSD)

… on Unitary or ZoneHVAC:WaterToAirHeatPump * OS:Coil:Cooling:WaterToAirHeatPump:EquationFit * OS:Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit * OS:Coil:Heating:WaterToAirHeatPump:EquationFit * OS:Coil:Cooling:DX:VariableSpeed

…m and ZoneHVACWaterToAirHeatPump

…onal) for all remaining 10 coils * OS:Coil:Cooling:DX:CurveFit:Performance * OS:Coil:Cooling:DX:SingleSpeed * OS:Coil:Cooling:DX:TwoStageWithHumidityControlMode * OS:Coil:Cooling:DX:MultiSpeed * OS:Coil:Heating:DX:SingleSpeed * OS:Coil:Heating:DX:MultiSpeed * OS:Coil:Heating:DX:VariableSpeed * OS:Coil:WaterHeating:AirToWaterHeatPump (:Pumped) * OS:Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed * OS:Coil:WaterHeating:AirToWaterHeatPump:Wrapped

… so pragma ignore

fix ruby test setup issues as well

jmarrec · 2023-09-04T10:29:49Z

src/model/AirLoopHVACUnitarySystem.cpp

+  double AirLoopHVACUnitarySystem::maximumCyclingRate() const {
+    DEPRECATED_AT_MSG(3, 7, 0,
+                      "As of EnergyPlus 23.2.0, this property is on the child cooling coil. Use coolingCoil()->maximumCyclingRate() instead.");
+    double result = 2.5;  // former default
+    if (auto c_ = coolingCoil()) {
+      if (auto c_eq_ = c_->optionalCast<CoilCoolingWaterToAirHeatPumpEquationFit>()) {
+        result = c_eq_->maximumCyclingRate();
+      } else if (auto c_vs_ = c_->optionalCast<CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit>()) {
+        result = c_vs_->maximumCyclingRate();
+      } else if (auto c_dx_ = c_->optionalCast<CoilCoolingDXVariableSpeed>()) {
+        result = c_dx_->maximumCyclingRate();
+      }
+    }
+    return result;
+  }


Deprecated the former model methods for the unitary systems, trying to set it on the child cooling coil.

Note: This is does not modify the "Part Load Fraction Correlation Curve" on the heating coil (which is created during VT using some calculations based on Max Cycling Rate and Heat Pump Time Constant). That would be very weird IMHO.
I actually considering just making the deprecated method be a no-op and return false

jmarrec · 2023-09-04T10:30:52Z

src/model/CoilCoolingDXTwoSpeed.hpp

+    double ratedHighSpeedEvaporatorFanPowerPerVolumeFlowRate2017() const;
+
+    double ratedHighSpeedEvaporatorFanPowerPerVolumeFlowRate2023() const;


Example for the new Fan power per vol flow rate 2017 / 2023. Added to model here.

jmarrec · 2023-09-04T10:31:12Z

src/energyplus/ForwardTranslator/ForwardTranslateCoilCoolingDXTwoSpeed.cpp

+    idfObject.setDouble(Coil_Cooling_DX_TwoSpeedFields::HighSpeedRatedEvaporatorFanPowerPerVolumeFlowRate2017,
+                        modelObject.ratedHighSpeedEvaporatorFanPowerPerVolumeFlowRate2017());
+    idfObject.setDouble(Coil_Cooling_DX_TwoSpeedFields::HighSpeedRatedEvaporatorFanPowerPerVolumeFlowRate2023,
+                        modelObject.ratedHighSpeedEvaporatorFanPowerPerVolumeFlowRate2023());


FT'ed here.

jmarrec · 2023-09-04T10:32:02Z

src/model/CoilWaterHeatingAirToWaterHeatPump.hpp

@@ -86,6 +86,8 @@ namespace model {

    double crankcaseHeaterCapacity() const;

+    boost::optional<Curve> crankcaseHeaterCapacityFunctionofTemperatureCurve() const;


cranckcase curve example. This curve is optional everywhere.

jmarrec · 2023-09-04T10:32:14Z

src/model/CoilWaterHeatingAirToWaterHeatPump.hpp

+    bool setCrankcaseHeaterCapacityFunctionofTemperatureCurve(const Curve& curve);
+    void resetCrankcaseHeaterCapacityFunctionofTemperatureCurve();


has a set and a reset accordingly

jmarrec · 2023-09-04T10:40:35Z

src/osversion/VersionTranslator.cpp

+      } else if (iddname == "OS:AirLoopHVAC:UnitarySystem") {
+
+        // Removed fields
+        // 38 - Maximum Cycling Rate
+        // 39 - Heat Pump Time Constant
+        // 40 - Fraction of On-Cycle Power Use
+        // 41 - Heat Pump Fan Delay Time
+
+        auto iddObject = idd_3_7_0.getObject(iddname);
+        IdfObject newObject(iddObject.get());
+
+        for (size_t i = 0; i < object.numFields(); ++i) {
+          if ((value = object.getString(i))) {
+            if (i < 38) {
+              newObject.setString(i, value.get());
+            } else if (i > 41) {
+              newObject.setString(i - 4, value.get());
+            }
+          }
+        }
+
+        m_refactored.push_back(RefactoredObjectData(object, newObject));
+        ss << newObject;
+
+        auto it = CoilLatentTransitionInfo::findFromParent(coilTransitionInfos, object);
+        if (it != coilTransitionInfos.end()) {
+          if (it->isCurveCreationNeeded()) {
+            IdfObject plfCurve = it->createCurveLinear(idd_3_7_0);
+            ss << plfCurve;
+            m_new.emplace_back(std::move(plfCurve));
+          }
+        }


When you get to a Unitary System / WAHP, you remove the fields.

You check if a Curve needs to be created, and only if so, you do it.

This ensures that if you have a Unitary System with a Coil:Heating:WaterToAirHeatPump:EquationFit AND a Coil:Cooling:WaterToAirHeatPump:EquationFit, you do create only one unique curve, for both objects to reference.

jmarrec · 2023-09-04T10:43:40Z

src/osversion/VersionTranslator.cpp

+      } else if (iddname == "OS:Coil:Cooling:WaterToAirHeatPump:EquationFit") {
+
+        // Fields that have been added from 3.6.1 to 3.7.0:
+        // ------------------------------------------------
+        // * Part Load Fraction Correlation Curve Name* 17
+        // New at end
+        // * Maximum Cycling Rate * 20
+        // * Latent Capacity Time Constant * 21
+        // * Fan Delay Time * 22
+
+        auto iddObject = idd_3_7_0.getObject(iddname);
+        IdfObject newObject(iddObject.get());
+
+        for (size_t i = 0; i < object.numFields(); ++i) {
+          if ((value = object.getString(i))) {
+            if (i < 17) {
+              newObject.setString(i, value.get());
+            } else {
+              newObject.setString(i + 1, value.get());
+            }
+          }
+        }
+
+        auto it = CoilLatentTransitionInfo::findFromCoolingCoil(coilTransitionInfos, object);
+        const bool hasCoilInfo = (it != coilTransitionInfos.end());
+        const std::string curveName = hasCoilInfo ? it->curveName() : fmt::format("{}-PLFCorrelationCurve", object.nameString());
+        newObject.setString(17, curveName);
+
+        double maxCyclingRate = 0.0;
+        double heatPumpTimeConst = 0.0;
+        double hpDelayTime = 60.0;
+        if (hasCoilInfo) {
+          maxCyclingRate = it->maxCyclingRate;
+          heatPumpTimeConst = it->heatPumpTimeConst;
+          hpDelayTime = it->hpDelayTime;
+        }
+
+        newObject.setDouble(20, maxCyclingRate);
+        newObject.setDouble(21, heatPumpTimeConst);
+        newObject.setDouble(22, hpDelayTime);
+
+        m_refactored.push_back(RefactoredObjectData(object, newObject));
+        ss << newObject;
+
+        if (!hasCoilInfo) {
+          IdfObject plfCurve = CoilLatentTransitionInfo::defaultHeatPumpCoilPLFCorrelationCurve(idd_3_7_0, curveName);
+          ss << plfCurve;
+          m_new.emplace_back(std::move(plfCurve));
+        }
+


When you get to a coil that is supposed to inherit from a potential unitary parent

If you have a unitary parent:

You use the values from the unitary, and the PLF curve name we generated automatically

You don't have a unitary parent:

You use the defaults from the IDD (moved to Ctor in model since I made it required-field)

You create a PLF curve calculated from these defaults

jmarrec · 2023-09-04T10:44:52Z

src/osversion/test/VersionTranslator_GTest.cpp

@@ -2548,3 +2553,892 @@ TEST_F(OSVersionFixture, update_3_6_1_to_3_7_0_GroundHeatExchangerVertical) {
  EXPECT_EQ(3.2, uka.getDouble(6).get());                                                       // Average Amplitude of Surface Temperature
  EXPECT_EQ(8.0, uka.getDouble(7).get());                                                       // Phase Shift of Minimum Surface Temperature
 }
+
+TEST_F(OSVersionFixture, update_3_6_1_to_3_7_0_Coils_RatedFanPowerPerVolumeFlowRate) {


LOTS of testing here

Easy, the 2017 / 2023 fan power per vol flow rate.

jmarrec · 2023-09-04T10:45:17Z

src/osversion/test/VersionTranslator_GTest.cpp

+  }
+}
+
+TEST_F(OSVersionFixture, update_3_6_1_to_3_7_0_Coils_CrankcaseCurve) {


Test all crankcase curve insertions

jmarrec · 2023-09-04T10:46:58Z

src/osversion/test/VersionTranslator_GTest.cpp

+  }
+}
+
+TEST_F(OSVersionFixture, update_3_6_1_to_3_7_0_Coils_Latent_solo) {


Starting here you have 600 lines of testing for the Coil Latent Stuff, testing all combinations of Unitary/Child coils I could think off. Making sure the PLF Curves are created properly, shared between HC and CC if appropriate, etc.

joseph-robertson

This one is certainly a beast. Looks like all the pieces are here: all the FT updates, model and test updates, VT and test updates. I'm surprised there wouldn't be more FT test updates? Also, do we want to handle the "Design Specification Multispeed Object Type" and "Design Specification Multispeed Object Name" additions here - or does it make sense to keep that separated?

joseph-robertson · 2023-09-06T16:40:33Z

resources/energyplus/ProposedEnergy+.idd

@@ -30845,7 +30849,7 @@ Coil:Cooling:DX:TwoSpeed,
       \minimum 0.0
       \maximum 1250.0
       \default 773.3
-  N13, \field Low Speed 2023 Rated Evaporator Fan Power Per Volume Flow Rate
+  N13, \field Low Speed Rated Evaporator Fan Power Per Volume Flow Rate 2023


This is the approach we've taken across all object/fields, right?

Yeah the reason is dumb, but this is because of our parser...

"Speed 1 field 2023" -> 1 is removed, 2023 is kept
"Speed 2023 field" -> 2023 is removed

joseph-robertson · 2023-09-06T16:42:34Z

src/energyplus/ForwardTranslator/ForwardTranslateCoilHeatingWaterToAirHeatPumpEquationFit.cpp

@@ -124,6 +124,14 @@ namespace energyplus {
      }
    }

+    // Part Load Fraction Correlation Curve Name


Should the PR description be updated for handling new part load fraction correlation curve fields? (similar to addition of crankcase)

I clarified it in the OP.

Coil Latent Stuff: - * Move some values from unitary systems to child object + * Move some values from unitary systems to child object: maximum Cycling Rate, Heat Pump Time Constant, Fan Delay Time => get moved as fields for cooling coil or as the "Part Load Fraction Correlation Curve" in case of heating

jmarrec · 2023-09-07T15:25:20Z

This one is certainly a beast. Looks like all the pieces are here: all the FT updates, model and test updates, VT and test updates. I'm surprised there wouldn't be more FT test updates?

I think I mostly got tired towards the end. Lots of these objects don't have good testing (or no testing) to begin with too.

You're right to mention it though, it's a good idea to add the tests... I'll muster the courage to write them.

Also, do we want to handle the "Design Specification Multispeed Object Type" and "Design Specification Multispeed Object Name" additions here - or does it make sense to keep that separated?

This is a gigantic PR already, so I figured we should do it separately.

…ToWaterHeatPump:(Pumped)/Wrapped)

jmarrec · 2023-09-12T12:50:08Z

resources/energyplus/ProposedEnergy+.idd

@@ -31279,7 +31279,7 @@ Coil:Cooling:DX:VariableSpeed,
        \memo wet coil when compressor cycles off with continuous fan operation. Requires two to
        \memo ten sets of performance data and will interpolate between speeds. Modeled as a
        \memo single coil with variable-speed compressor.
-        \extensible:10
+        \extensible:12


Fix extensible

jmarrec · 2023-09-12T12:50:12Z

resources/energyplus/ProposedEnergy+.idd

@@ -32901,7 +32901,7 @@ Coil:Heating:DX:VariableSpeed,
        \memo (includes electric compressor and outdoor fan), variable-speed, with defrost
        \memo controls. Requires two to ten sets of performance data and will interpolate between
        \memo speeds.
-        \extensible:7
+        \extensible:9


Fix extensible

jmarrec · 2023-09-12T12:50:29Z

src/model/CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit.cpp

@@ -376,7 +376,7 @@ namespace model {
      const CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFitSpeedData& speed) {
      auto modelObjectList = speedDataList();
      if (modelObjectList) {
-        modelObjectList->addModelObject(speed);
+        return modelObjectList->addModelObject(speed);


Some addSpeed methods weren't returning true on success

jmarrec · 2023-09-12T12:50:56Z

src/model/test/CoilHeatingDXVariableSpeed_GTest.cpp

+  Model m;
+  CoilHeatingDXVariableSpeed coil(m);
+
+  // Indoor Air Inlet Node Name: Required Object
+  // Indoor Air Outlet Node Name: Required Object
+
+  // Nominal Speed Level: Required Integer
+  EXPECT_EQ(1, coil.nominalSpeedLevel());
+  EXPECT_TRUE(coil.setNominalSpeedLevel(5));
+  EXPECT_EQ(5, coil.nominalSpeedLevel());
+
+  // Rated Heating Capacity At Selected Nominal Speed Level: Required Double
+  EXPECT_TRUE(coil.isRatedHeatingCapacityAtSelectedNominalSpeedLevelAutosized());
+  // Set
+  EXPECT_TRUE(coil.setRatedHeatingCapacityAtSelectedNominalSpeedLevel(1000.6));
+  ASSERT_TRUE(coil.ratedHeatingCapacityAtSelectedNominalSpeedLevel());
+  EXPECT_EQ(1000.6, coil.ratedHeatingCapacityAtSelectedNominalSpeedLevel().get());
+  EXPECT_FALSE(coil.isRatedHeatingCapacityAtSelectedNominalSpeedLevelAutosized());
+  // Autosize
+  coil.autosizeRatedHeatingCapacityAtSelectedNominalSpeedLevel();
+  EXPECT_TRUE(coil.isRatedHeatingCapacityAtSelectedNominalSpeedLevelAutosized());


Add model tests for some that were really untested

jmarrec · 2023-09-12T12:51:23Z

src/energyplus/CMakeLists.txt

+  Test/CoilCoolingWaterToAirHeatPumpEquationFit_GTest.cpp
+  Test/CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit_GTest.cpp
  Test/CoilHeatingDXMultiSpeed_GTest.cpp
+  Test/CoilHeatingDXSingleSpeed_GTest.cpp
+  Test/CoilHeatingDXVariableSpeed_GTest.cpp
  Test/CoilHeatingElectricMultiStage_GTest.cpp
  Test/CoilHeatingGas_GTest.cpp
  Test/CoilHeatingGasMultiStage_GTest.cpp
+  Test/CoilHeatingWaterToAirHeatPumpEquationFit_GTest.cpp
+  Test/CoilHeatingWaterToAirHeatPumpVariableSpeedEquationFit_GTest.cpp
  Test/CoilSystemIntegratedHeatPumpAirSource_GTest.cpp
  Test/CoilUserDefined_GTest.cpp
+  Test/CoilWaterHeatingAirToWaterHeatPump_GTest.cpp
+  Test/CoilWaterHeatingAirToWaterHeatPumpWrapped_GTest.cpp


Lots of brand new tests for objects that had no FT tests. Testing all fields

jmarrec · 2023-09-12T12:52:05Z

src/energyplus/Test/CoilCoolingDXSingleSpeed_GTest.cpp

+  ScheduleConstant availSch(m);
+  availSch.setName("Coil Avail Sch");
+  CurveBiquadratic totalCoolingCapacityFunctionOfTemperatureCurve(m);
+  totalCoolingCapacityFunctionOfTemperatureCurve.setName("totalCoolingCapacityFunctionOfTemperatureCurve");
+  CurveQuadratic totalCoolingCapacityFunctionOfFlowFractionCurve(m);
+  totalCoolingCapacityFunctionOfFlowFractionCurve.setName("totalCoolingCapacityFunctionOfFlowFractionCurve");
+  CurveBiquadratic energyInputRatioFunctionOfTemperatureCurve(m);
+  energyInputRatioFunctionOfTemperatureCurve.setName("energyInputRatioFunctionOfTemperatureCurve");
+  CurveQuadratic energyInputRatioFunctionOfFlowFractionCurve(m);
+  energyInputRatioFunctionOfFlowFractionCurve.setName("energyInputRatioFunctionOfFlowFractionCurve");
+  CurveQuadratic partLoadFractionCorrelationCurve(m);
+  partLoadFractionCorrelationCurve.setName("partLoadFractionCorrelationCurve");
+
+  CoilCoolingDXSingleSpeed coil(m, availSch, totalCoolingCapacityFunctionOfTemperatureCurve, totalCoolingCapacityFunctionOfFlowFractionCurve,
+                                energyInputRatioFunctionOfTemperatureCurve, energyInputRatioFunctionOfFlowFractionCurve,
+                                partLoadFractionCorrelationCurve);
+
+  AirLoopHVAC a(m);
+  auto supplyOutletNode = a.supplyOutletNode();
+  EXPECT_TRUE(coil.addToNode(supplyOutletNode));
+
+  a.supplyInletNode().setName("Supply Inlet Node");
+  a.supplyOutletNode().setName("Supply Outlet Node");
+
+  EXPECT_TRUE(coil.setName("Coil Cooling DX Single Speed"));
+  EXPECT_EQ(availSch, coil.availabilitySchedule());
+  EXPECT_TRUE(coil.setRatedTotalCoolingCapacity(2000.0));
+  EXPECT_TRUE(coil.setRatedSensibleHeatRatio(0.8));
+  EXPECT_TRUE(coil.setRatedCOP(4.0));
+  EXPECT_TRUE(coil.setRatedAirFlowRate(0.9));
+  EXPECT_TRUE(coil.setRatedEvaporatorFanPowerPerVolumeFlowRate2017(817.0));
+  EXPECT_TRUE(coil.setRatedEvaporatorFanPowerPerVolumeFlowRate2023(823.0));
+  EXPECT_EQ(totalCoolingCapacityFunctionOfTemperatureCurve, coil.totalCoolingCapacityFunctionOfTemperatureCurve());
+  EXPECT_EQ(totalCoolingCapacityFunctionOfFlowFractionCurve, coil.totalCoolingCapacityFunctionOfFlowFractionCurve());
+  EXPECT_EQ(energyInputRatioFunctionOfTemperatureCurve, coil.energyInputRatioFunctionOfTemperatureCurve());
+  EXPECT_EQ(energyInputRatioFunctionOfFlowFractionCurve, coil.energyInputRatioFunctionOfFlowFractionCurve());
+  EXPECT_EQ(partLoadFractionCorrelationCurve, coil.partLoadFractionCorrelationCurve());
  coil.setMinimumOutdoorDryBulbTemperatureforCompressorOperation(-7.5);
+  EXPECT_TRUE(coil.setNominalTimeForCondensateRemovalToBegin(6.0));
+  EXPECT_TRUE(coil.setRatioOfInitialMoistureEvaporationRateAndSteadyStateLatentCapacity(0.2));
+  EXPECT_TRUE(coil.setMaximumCyclingRate(3.2));
+  EXPECT_TRUE(coil.setLatentCapacityTimeConstant(62.0));
+  EXPECT_TRUE(coil.setCondenserType("EvaporativelyCooled"));
+  EXPECT_TRUE(coil.setEvaporativeCondenserEffectiveness(0.85));
+  EXPECT_TRUE(coil.setEvaporativeCondenserAirFlowRate(1.2));
+  EXPECT_TRUE(coil.setEvaporativeCondenserPumpRatedPowerConsumption(51.0));
+  EXPECT_TRUE(coil.setCrankcaseHeaterCapacity(105.0));
+  CurveLinear crankCurve(m);
+  crankCurve.setName("CrankHeatCapFT");
+  EXPECT_TRUE(coil.setCrankcaseHeaterCapacityFunctionofTemperatureCurve(crankCurve));
+
+  EXPECT_TRUE(coil.setMaximumOutdoorDryBulbTemperatureForCrankcaseHeaterOperation(9.0));
+  EXPECT_TRUE(coil.setBasinHeaterCapacity(90.0));
+  EXPECT_TRUE(coil.setBasinHeaterSetpointTemperature(5.0));
+  ScheduleConstant basinSch(m);
+  basinSch.setName("Coil Basin Sch");
+  coil.setBasinHeaterOperatingSchedule(basinSch);


Existing test that had very low coverage: test all fields

…d something more robust, but not bothering now

…Parameters cf NREL/EnergyPlus#10215 (comment)

ci-commercialbuildings · 2023-09-12T15:47:28Z

CI Results for 53a7202:

Ubuntu 20.04:
Ubuntu 22.04:
- OpenStudio-3.7.0-alpha+2ed149f1b5-Ubuntu-22.04-x86_64.deb
- OpenStudio-3.7.0-alpha+2ed149f1b5-Ubuntu-22.04-x86_64.tar.gz
Darwin:
- OpenStudio-3.7.0-alpha+a6446039cf-Darwin-x86_64.dmg
- OpenStudio-3.7.0-alpha+a6446039cf-Darwin-x86_64.tar.gz
Windows:
Code Coverage:

jmarrec added 15 commits August 31, 2023 11:21

Add the Rated XXX Fan Power Per Volume Flow Rate fields for DX Coils …

dbf3080

…(Two Speed and VSD)

Mistake in VT for SpeedData fields

54e49a6

Remove maximumCycling Rate and co fields from AirLoopHVACUnitarySyste…

5c8a97a

…m and ZoneHVACWaterToAirHeatPump

VT + VT tests for the Crankcase curve

98fc94c

WIP VT for Coil Latent Stuff (Unitary > Child coils)

a9a638f

Fix E+ idd issues

ec23a61

Re-add stupid overloads that take a boost::optional<double>

b71d372

Start adding VT tests for the Coil Latent

d0e34d6

adjust latent coil VT

824f101

Mislabeled the parameters with units in the PLF creation

89d7b51

More testing for Coil Latent (missing the VSD + WAHP ones)

e2343b6

overloads that take a boost::optional<double> use deprecated methods,…

07343f6

… so pragma ignore

Wrap up VersionTranslator testing!

879a518

fix ruby test setup issues as well

jmarrec added component - HVAC component - Version Translator Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Sep 4, 2023

jmarrec requested a review from joseph-robertson September 4, 2023 10:26

jmarrec self-assigned this Sep 4, 2023

jmarrec commented Sep 4, 2023

View reviewed changes

This was referenced Sep 4, 2023

Update to EnergyPlus 23.2.0 #4934

Closed

CoilHeatingWaterToAirHeatPumpEquationFit: new Part Load Fraction Correlation Curve field #4955

Closed

joseph-robertson reviewed Sep 6, 2023

View reviewed changes

jmarrec added 4 commits September 12, 2023 11:23

Bump extensible in ProposedEnergy+.idd, cf #4940 (review)

21062bd

Add full testing for all coil objects (Missing: Coil:WaterHeating:Air…

03352ae

…ToWaterHeatPump:(Pumped)/Wrapped)

Wrap up FT testing

c7d4075

Fix DX VSD addSpeed not retuning true on success

c792e07

jmarrec commented Sep 12, 2023

View reviewed changes

jmarrec requested a review from joseph-robertson September 12, 2023 12:52

jmarrec added 2 commits September 12, 2023 16:21

Fix the VT tests from previous versions. At some point we should buil…

8d7ce7d

…d something more robust, but not bothering now

Unrelated: but there is a duplicated field name in the ZoneEarthTube:…

53a7202

…Parameters cf NREL/EnergyPlus#10215 (comment)

jmarrec merged commit d0e00ef into v23.2.0-IOFreeze Sep 12, 2023

jmarrec deleted the v23.2.0-IOFreeze-Coils branch September 12, 2023 18:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v23.2.0-IOFreeze: Coil and Unitary systems changes #4958

v23.2.0-IOFreeze: Coil and Unitary systems changes #4958

jmarrec commented Sep 4, 2023 •

edited

Loading

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

jmarrec Sep 4, 2023

joseph-robertson left a comment

joseph-robertson Sep 6, 2023

jmarrec Sep 7, 2023 •

edited

Loading

joseph-robertson Sep 6, 2023

jmarrec Sep 7, 2023

jmarrec commented Sep 7, 2023

jmarrec Sep 12, 2023

jmarrec Sep 12, 2023

jmarrec Sep 12, 2023

jmarrec Sep 12, 2023

jmarrec Sep 12, 2023

jmarrec Sep 12, 2023

ci-commercialbuildings commented Sep 12, 2023 •

edited

Loading

	constexpr std::array<std::pair<std::string_view, size_t>, 10> crankcaseCoilWithIndex{{
	{"OS:Coil:Cooling:DX:CurveFit:Performance", 3},
	{"OS:Coil:Cooling:DX:SingleSpeed", 27},
	{"OS:Coil:Cooling:DX:TwoStageWithHumidityControlMode", 6},
	{"OS:Coil:Cooling:DX:MultiSpeed", 13},
	{"OS:Coil:Heating:DX:SingleSpeed", 19},
	{"OS:Coil:Heating:DX:MultiSpeed", 8},
	{"OS:Coil:Heating:DX:VariableSpeed", 13},
	{"OS:Coil:WaterHeating:AirToWaterHeatPump", 20},
	{"OS:Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed", 18},
	{"OS:Coil:WaterHeating:AirToWaterHeatPump:Wrapped", 13},
	}};

		double ratedHighSpeedEvaporatorFanPowerPerVolumeFlowRate2017() const;

		double ratedHighSpeedEvaporatorFanPowerPerVolumeFlowRate2023() const;

		@@ -86,6 +86,8 @@ namespace model {

		double crankcaseHeaterCapacity() const;

		boost::optional<Curve> crankcaseHeaterCapacityFunctionofTemperatureCurve() const;

		bool setCrankcaseHeaterCapacityFunctionofTemperatureCurve(const Curve& curve);
		void resetCrankcaseHeaterCapacityFunctionofTemperatureCurve();

v23.2.0-IOFreeze: Coil and Unitary systems changes #4958

v23.2.0-IOFreeze: Coil and Unitary systems changes #4958

Conversation

jmarrec commented Sep 4, 2023 • edited Loading

Pull request overview

Pull Request Author

Review Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joseph-robertson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec commented Sep 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ci-commercialbuildings commented Sep 12, 2023 • edited Loading

jmarrec commented Sep 4, 2023 •

edited

Loading

jmarrec Sep 7, 2023 •

edited

Loading

ci-commercialbuildings commented Sep 12, 2023 •

edited

Loading