Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoilHeatingWaterToAirHeatPumpEquationFit: new Part Load Fraction Correlation Curve field #4955

Closed
wants to merge 7 commits into from

Conversation

joseph-robertson
Copy link
Collaborator

Pull request overview

  • Support new "Part Load Fraction Correlation Curve" field for Coil:Heating:WaterToAirHeatPump:EquationFit.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Aug 30, 2023
@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.7.0 milestone Aug 30, 2023
@joseph-robertson joseph-robertson self-assigned this Aug 30, 2023
@joseph-robertson joseph-robertson mentioned this pull request Aug 30, 2023
26 tasks
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 4, 2023

@joseph-robertson This is already handled as part of #4958 FYI.

@joseph-robertson
Copy link
Collaborator Author

Handled as part of #4958.

@joseph-robertson joseph-robertson deleted the coil-htg-wtahp-eqnfit branch September 5, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants