Feature coldpool #34
Merged
Feature coldpool #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…needs to be cleaned up
…pool index generate function name
only annual time series is output. monthly time series will be implemented when talk with CEFI folks
extract the mask creating part out of the index module
|
@chiaweh2 The cold pool index logic has passed my tests and I believe it's good to go to the development branch. Please take a look and let me know if you think anything needs to change. Thanks! |
chiaweh2
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will implement the cold pool index within the mom6 index module that will generate the index based on the current mask data that we have. These changes also include methods to generate and retrieve the mask based on GLORYS data. This is intended to be a temporary change until we have access to the mask data used in the Ross et al., 2023 paper.