Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlay lighting messing up alert overlays #3908

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix overlay lighting messing up alert overlays #3908

merged 2 commits into from
Oct 23, 2024

Commits on Oct 23, 2024

  1. [NO GBP] Fix overlay lighting messing up alert overlays (#87362) 

    Closes tgstation/tgstation#87357

Adds a `IS_LIGHTING_UNDERLAY` define, and a `strip_light_underlays`
helper that uses it (thanks @Kapu1178 for the code)

![2024-10-21 (1729553782) ~
dreamseeker](https://github.com/user-attachments/assets/da2778f9-40e0-4760-85aa-a17a7d05f01c)

![2024-10-21 (1729553540) ~
dreamseeker](https://github.com/user-attachments/assets/dd240c83-faf9-4e55-b913-58743aa764f0)

:cl: Absolucy, Kapu
fix: Fix overlay lighting (such as lanterns) messing up alert overlays,
i.e the rod of asclepius alert.
/:cl:
    @Absolucy
    Absolucy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    170d49e View commit details
    Browse the repository at this point in the history

  2. Apply fixes to heretic living heart, too.

    @Absolucy
    Absolucy committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d8f15a9 View commit details
    Browse the repository at this point in the history