Fix overlay lighting messing up alert overlays #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
changed the title
This was referenced Oct 22, 2024
This was referenced Oct 22, 2024
Closes tgstation/tgstation#87357 Adds a `IS_LIGHTING_UNDERLAY` define, and a `strip_light_underlays` helper that uses it (thanks @Kapu1178 for the code)   :cl: Absolucy, Kapu fix: Fix overlay lighting (such as lanterns) messing up alert overlays, i.e the rod of asclepius alert. /:cl:
Absolucy
force-pushed
the
strip-underlays
branch
from
a390474
to
170d49e
Compare
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Port of my own PR: tgstation/tgstation#87362
Changelog
🆑
fix: Fix overlay lighting (such as lanterns) messing up alert overlays, i.e the rod of asclepius alert, and the living heart selection.
/:cl: