Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing error if user file is broken #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jerome226
Copy link

Catch errors if the EA user file is broken to avoid erroring at launch.
Should fix the issue correctly.

@Jerome226
Copy link
Author

Jerome226 commented Aug 6, 2024

@Holt59 You can delete the other PR I made. This is an actual fix. Sorry for any inconvenience.

@Jerome226 Jerome226 mentioned this pull request Aug 6, 2024
@Silarn
Copy link
Member

Silarn commented Aug 7, 2024

This may prevent the error but it doesn't really resolve the issue since it will fail to parse any ea games by returning early.

Perhaps the better solution would be an error message that gives the user useful info and allows them to correct the issue. Assuming it's not still possible to grab the value from the file.

@Jerome226
Copy link
Author

Jerome226 commented Aug 7, 2024

This may prevent the error but it doesn't really resolve the issue since it will fail to parse any ea games by returning early.

Perhaps the better solution would be an error message that gives the user useful info and allows them to correct the issue.

image
Like this?

@Jerome226
Copy link
Author

Jerome226 commented Aug 7, 2024

This may prevent the error but it doesn't really resolve the issue since it will fail to parse any ea games by returning early.

Perhaps the better solution would be an error message that gives the user useful info and allows them to correct the issue. Assuming it's not still possible to grab the value from the file.

This only happen in rare case, this commit is simply to avoid a big error popup everytime.
The fix it is to login into EA and launch the launcher.
But the current error popup simply talks about python stuff and that doesn't really help the user at finding why their mod organizer is erroring everytime.
Adding a simple print after the error catching would tell the user in the logs that the ini file can't be parsed like its done in other python files currently (like epic_utils.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants