Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PR #153

Closed
wants to merge 1 commit into from
Closed

Conversation

Jerome226
Copy link

@Jerome226 Jerome226 commented Aug 5, 2024

No description provided.

@Holt59
Copy link
Member

Holt59 commented Aug 6, 2024

I really doubt that "EA" is what fixed the issue. Most likely what fixed the issue is you opening and saving the file, that probably removes the chunk of bad characters that present.

@Jerome226
Copy link
Author

It actually seems like I can put anything in the "" that is a letter and it works. I have no idea what's happening.

@Jerome226
Copy link
Author

Yeah no I just made this not work at all. Completely incompetant on my part.

@Holt59
Copy link
Member

Holt59 commented Aug 6, 2024

It actually seems like I can put anything in the "" that is a letter and it works. I have no idea what's happening.

I misread the change, actually if you add anything here, this changes the behavior of the next lines because ea_desktop_settings_path will not exist.

Maybe you have broken ini files in the EA Desktop folders, I remember people having similar issues... Can you check the user_*.ini files under %LocalAppData%/Electronic Arts/EA Desktop"? Maybe simply try opening/closing the EA Desktop App to fix the files.

@Jerome226
Copy link
Author

Jerome226 commented Aug 6, 2024

It actually seems like I can put anything in the "" that is a letter and it works. I have no idea what's happening.

I misread the change, actually if you add anything here, this changes the behavior of the next lines because ea_desktop_settings_path will not exist.

Maybe you have broken ini files in the EA Desktop folders, I remember people having similar issues... Can you check the user_*.ini files under %LocalAppData%/Electronic Arts/EA Desktop"? Maybe simply try opening/closing the EA Desktop App to fix the files.

Alright well excuse me for my incompetance. Reading a bit more of the code. I found an actual solution.
image
Adding a except if it gets a ValueError prevent the application from erroring.
This will only catch if the file has non correct characters when something like on my end where it breaks.

@Jerome226 Jerome226 closed this Aug 6, 2024
@Jerome226 Jerome226 deleted the fix-parsing-error branch August 6, 2024 07:40
@Jerome226 Jerome226 restored the fix-parsing-error branch August 6, 2024 07:40
@Jerome226 Jerome226 deleted the fix-parsing-error branch August 6, 2024 07:40
@Jerome226 Jerome226 changed the title Fix Source contains parsing errors: '<string>' with EAUtils Ignore PR Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants